Bug 215523 - Support for opening multiple Schema HTML Viewers
Summary: Support for opening multiple Schema HTML Viewers
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M5   Edit
Assignee: Les Jones CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2008-01-16 12:07 EST by Simon Archer CLA
Modified: 2008-02-05 15:39 EST (History)
2 users (show)

See Also:

Attachments
Allow multiple Schema HTML viewers (but only one per exsd) (1.10 KB, patch)
2008-01-16 13:51 EST, Les Jones CLA 		no flags Details | Diff
mylyn/context/zip (1.02 KB, application/octet-stream)
2008-01-17 11:44 EST, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Archer CLA 2008-01-16 12:07:03 EST 
Today it is not easy to open multiple Schema HTML Viewers.  When you have multiple .exsd files that you what to visually inspect, possibly side-by-side, opening the second file replaces the first in the Schema HTML Viewer.

But there is a sneaky work-around, which makes me think that this should not be too difficult to support directly.

1.  Open the first .exsd file in the Schema HTML Viewer.
2.  Right click on the viewer's tab and choose "New Editor".
3.  Open the second .exsd file and it'll show up in one of the 2 open viewers.

It would be nice to just have PDE open a new Schema HTML Viewer rather than replacing the contents of an already open viewer.
Comment 1 Les Jones CLA 2008-01-16 13:51:12 EST 
Created attachment 87078 [details]
Allow multiple Schema HTML viewers (but only one per exsd)

Possible patch; quite simple, could perhaps be more elegant - but I get the uniqueness check from the file name of the generated temporary HTML file. Should be fairly unique to this scenario allowing multiple opens of the same schema to share the same editor, with other schemas opening in different editors.

All that said, depending on expected behavior; this may be worthy of a preference to govern the choice?
Comment 2 Chris Aniszczyk CLA 2008-01-16 14:13:12 EST 
Thanks Les, you rock. We'll try to look at it ASAP.

On the other hand, it looks like the PDE Slayer is busy messing with schemas lately :)
Comment 3 Simon Archer CLA 2008-01-16 14:30:06 EST 
Yeah, I'm the local ExtensionPoint/RegistryReading Slayer theses days.  I wrangle with the schema editor a lot.  :-)

The Schema HTML Viewer is awesome, btw.  Undocumented extension points are just horrible to deal with, so I use the viewer a lot.

Thank you Les contributing the fix.
Comment 4 Les Jones CLA 2008-01-17 03:53:49 EST 
If you think it warrants a preference to control the behavior, just let me know and I'll enhance it for you; I guess it just depends what the initial rationale for re-using the same editor window was.
Comment 5 Chris Aniszczyk CLA 2008-01-17 11:44:01 EST 
thanks Les, best patch ever to review ;)
Comment 6 Chris Aniszczyk CLA 2008-01-17 11:44:05 EST 
Created attachment 87167 [details]
mylyn/context/zip
Comment 7 Brian Bauman CLA 2008-02-05 15:39:34 EST 
Verified on I20080204-0010