Bug 215361 - Support differing log levels
Summary: Support differing log levels
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M6   Edit
Assignee: equinox.framework-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-01-15 11:17 EST by Chris Gross CLA
Modified: 2008-02-13 14:19 EST (History)
2 users (show)

See Also:

Attachments
Log level patch (3.47 KB, patch)
2008-01-15 11:17 EST, Chris Gross CLA 		no flags Details | Diff
modified (3.79 KB, patch)
2008-01-15 13:54 EST, Thomas Watson CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Gross CLA 2008-01-15 11:17:48 EST 
Created attachment 86949 [details]
Log level patch

We need to support different levels of logging (debug, info, warning, etc). 

We quickly (and perhaps not too cleanly) added support ourselves.  I'm attaching a patch but it might not be very useful to real support of this feature (but I need to fulfill my responsibilities under the EPL).
Comment 1 Thomas Watson CLA 2008-01-15 13:50:57 EST 
I could not apply the attached patch with Eclipse.  Not sure why, the patch look ok to me.  I will attach another patch.
Comment 2 Thomas Watson CLA 2008-01-15 13:54:01 EST 
Created attachment 86964 [details]
modified

Updated patch.  I modified it slightly.  The default should be to log everything, even OK status messages like it did before.  I also changed the patch to use the bit masks calculations instead of doing several == tests to check the loglevel.
Comment 3 Thomas Watson CLA 2008-02-13 14:19:00 EST 
I released the patch.