Bug 215314 - manifest editor content assist: additional info has wrong status text
Summary: manifest editor content assist: additional info has wrong status text
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: 3.6 M1   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2008-01-15 04:17 EST by Dani Megert CLA
Modified: 2009-07-29 07:05 EDT (History)
2 users (show)

See Also:


Attachments
Patch that removes the F2 message (1.42 KB, patch)
2008-04-15 17:02 EDT, Peter Friese CLA
contact: iplog+
Details | Diff
mylyn/context/zip (790 bytes, application/octet-stream)
2008-04-15 17:02 EDT, Peter Friese CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2008-01-15 04:17:12 EST
3.3 and 3.4 builds

If you trigger content assist in a manifest.mf file you get nice additional info for each entry on the right side. This window shows a wrong hint in the status line: "Press 'F2' for focus".
Comment 1 Peter Friese CLA 2008-02-28 17:30:55 EST
What's wrong with the status line text? Should it be removed?
Comment 2 Benjamin Cabé CLA 2008-02-28 17:41:57 EST
The problem Daniel describes is that when you trigger contentassist to select a new header, you've got a popup where you can choose your header (Bundle-Category, Bundle-Classpath, etc).
As soon as an entry in the list displayed in that popup is selected, a "subtooltip" is shown, and tells you that pressing F2 will give focus. But it don't. The best approach IMHO would be to keep the status line, and to forward the focus request to the second popup. My $0.02...
Comment 3 Peter Friese CLA 2008-02-28 19:17:23 EST
To me, the flyout tooltip in the PDE manifest editor (which we are talking about) looks quite different from the flyout tooltip in JDT. Maybe we should harmonize this for the sake of a more homogenous user experience. 

How about removing the "press F2" hint alltogether? I mean, what sense does it make to focus the tooltip? Does anyone need to copy text out of the tooltip window? Do we have any tooltip texts that exced the available space so one might want to scroll? I don't think so. 

Thus, I suggest removing the F2 hint.
Comment 4 Peter Friese CLA 2008-02-28 19:18:29 EST
Forgot to mention: the JDT tooltip flyout does not have an F2 hint.
Comment 5 Dani Megert CLA 2008-02-29 03:24:16 EST
>Thus, I suggest removing the F2 hint.
Exactly. There will be some changes in the underlying code assist for 3.4 that will allow to move focus into the additional info but until then PDE should simply remove that F2 hint.
Comment 6 Chris Aniszczyk CLA 2008-04-15 11:21:22 EDT
Is there an obvious way to do this? I browsed the code for a few minutes and couldn't find how to remove the F2 message.
Comment 7 Dani Megert CLA 2008-04-15 12:05:27 EDT
Pass 'null' instead of EditorsUI.getTooltipAffordanceString()
in org.eclipse.pde.internal.ui.editor.contentassist.TypeCompletionProposal.getInformationControlCreator()

HTH
Dani
Comment 8 Peter Friese CLA 2008-04-15 17:02:02 EDT
Created attachment 96170 [details]
Patch that removes the F2 message

The patch removes the F2 message by passing in "null", as suggested by Dani. Sorry for not taking care of this for so long... In fact, a patch had been lurking in my workspace for quite some time - however, I had passed in the empy string.
Comment 9 Peter Friese CLA 2008-04-15 17:02:06 EDT
Created attachment 96171 [details]
mylyn/context/zip
Comment 10 Benjamin Cabé CLA 2009-07-29 04:12:02 EDT
available in HEAD>20090729 ; thanks  :)