Bug 214914 - NPE in FilteredPluginArtifactsSelectionDialog while restoring history
Summary: NPE in FilteredPluginArtifactsSelectionDialog while restoring history
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M5   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2008-01-10 11:16 EST by Markus Keller CLA
Modified: 2008-01-10 14:38 EST (History)
1 user (show)

See Also:


Attachments
org.eclipse.pde.ui.patch (14.52 KB, patch)
2008-01-10 14:35 EST, Chris Aniszczyk CLA
no flags Details | Diff
mylyn/context/zip (847 bytes, application/octet-stream)
2008-01-10 14:35 EST, Chris Aniszczyk CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-01-10 11:16:24 EST
I20080108-1320

When I press Ctrl+Shift+A, I only get this NPE in the log:

Error
Thu Jan 10 17:13:29 CET 2008
Unhandled event loop exception

java.lang.NullPointerException
	at org.eclipse.pde.internal.ui.search.dialogs.FilteredPluginArtifactsSelectionDialog$PluginSearchSelectionHistory.restoreItemFromMemento(FilteredPluginArtifactsSelectionDialog.java:364)
	at org.eclipse.ui.dialogs.FilteredItemsSelectionDialog$SelectionHistory.load(FilteredItemsSelectionDialog.java:2270)
	at org.eclipse.ui.dialogs.FilteredItemsSelectionDialog$ContentProvider.loadHistory(FilteredItemsSelectionDialog.java:2775)
	at org.eclipse.ui.dialogs.FilteredItemsSelectionDialog.restoreDialog(FilteredItemsSelectionDialog.java:367)
	at org.eclipse.pde.internal.ui.search.dialogs.FilteredPluginArtifactsSelectionDialog.restoreDialog(FilteredPluginArtifactsSelectionDialog.java:327)
	at org.eclipse.ui.dialogs.FilteredItemsSelectionDialog.createDialogArea(FilteredItemsSelectionDialog.java:761)
	at org.eclipse.jface.dialogs.Dialog.createContents(Dialog.java:759)
	at org.eclipse.jface.window.Window.create(Window.java:431)
	at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1088)
	at org.eclipse.ui.dialogs.SelectionStatusDialog.create(SelectionStatusDialog.java:153)
	at org.eclipse.ui.dialogs.FilteredItemsSelectionDialog.create(FilteredItemsSelectionDialog.java:340)
	at org.eclipse.jface.window.Window.open(Window.java:790)
	at org.eclipse.pde.internal.ui.search.dialogs.PluginArtifactSearchHandler.execute(PluginArtifactSearchHandler.java:35)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:239)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:475)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:470)
	at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:165)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.executeCommand(WorkbenchKeyboard.java:470)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.press(WorkbenchKeyboard.java:821)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.processKeyEvent(WorkbenchKeyboard.java:879)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.filterKeySequenceBindings(WorkbenchKeyboard.java:568)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.access$3(WorkbenchKeyboard.java:510)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard$KeyDownFilter.handleEvent(WorkbenchKeyboard.java:126)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
	at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1160)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:951)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:976)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:961)
	at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:989)
	at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:985)
	at org.eclipse.swt.widgets.Widget.wmChar(Widget.java:1301)
	at org.eclipse.swt.widgets.Control.WM_CHAR(Control.java:3883)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:3776)
	at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:334)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:4458)
	at org.eclipse.swt.internal.win32.OS.$$YJP$$CallWindowProcW(Native Method)
	at org.eclipse.swt.internal.win32.OS.CallWindowProcW(OS.java)
	at org.eclipse.swt.internal.win32.OS.CallWindowProc(OS.java:2244)
	at org.eclipse.swt.internal.BidiUtil.windowProc(BidiUtil.java:657)
	at org.eclipse.swt.internal.win32.OS.$$YJP$$DispatchMessageW(Native Method)
	at org.eclipse.swt.internal.win32.OS.DispatchMessageW(OS.java)
	at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2330)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3367)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2392)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2356)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2222)
	at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:474)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:469)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:193)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:362)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:175)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:561)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:501)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1239)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1215)
Comment 1 Chris Aniszczyk CLA 2008-01-10 14:35:57 EST
Created attachment 86593 [details]
org.eclipse.pde.ui.patch

We always assumed whatever we retrieved from history would be in the current model. This isn't always true as bundles come and go when you develop :)
Comment 2 Chris Aniszczyk CLA 2008-01-10 14:35:59 EST
Created attachment 86594 [details]
mylyn/context/zip
Comment 3 Chris Aniszczyk CLA 2008-01-10 14:36:50 EST
mine
Comment 4 Chris Aniszczyk CLA 2008-01-10 14:38:16 EST
anything for Markus :)