Bug 214686 - if one closes a freshly "prepared" ChangeLog, it should not exist
Summary: if one closes a freshly "prepared" ChangeLog, it should not exist
Status: CLOSED INVALID
Alias: None
Product: Linux Tools
Classification: Tools
Component: ChangeLog (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.4   Edit
Assignee: Jeff Johnston CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2008-01-08 17:26 EST by Andrew Overholt CLA
Modified: 2009-11-02 16:05 EST (History)
2 users (show)

See Also:


Attachments
proposed patch for bug (2.40 KB, patch)
2009-10-16 17:03 EDT, Roland Grunberg CLA
no flags Details | Diff
revised patch (2.44 KB, patch)
2009-10-20 15:09 EDT, Roland Grunberg CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2008-01-08 17:26:29 EST
SSIA
Comment 1 Andrew Overholt CLA 2008-09-30 14:13:05 EDT
Tentatively setting 1.0 target.
Comment 2 Andrew Overholt CLA 2009-01-13 16:05:23 EST
The file seems to be getting created.  Perhaps we can temporarily create a buffer and not a file?  Let's try to get this fixed for 0.2.
Comment 3 Roland Grunberg CLA 2009-10-16 17:03:54 EDT
Created attachment 149796 [details]
proposed patch for bug

- Keeps track of when a fresh ChangeLog has been created.
- Keeps track of when a ChangeLog is saved.

Listens for a ChangeLog file being closed, and if the file is newly created, and has not been saved, then it is deleted.
Comment 4 Roland Grunberg CLA 2009-10-20 15:09:25 EDT
Created attachment 150018 [details]
revised patch

A ChangeLog that is retrieved has been saved before. Therefore closing one where recent changes have not been saved should not cause it to be deleted.
Comment 5 Roland Grunberg CLA 2009-10-28 12:13:48 EDT
I've looked over how other wizards or file creation processes deal with new files, and it seems they create a new file and have it saved with some basic content (comments/imports), or just empty. I guess the ChangeLog plugin should try to mimic that type of functionality, so in this case, a newly created ChangeLog when closed without saving should remain.
Comment 6 Andrew Overholt CLA 2009-10-28 14:26:02 EDT
If that's how other editors and wizards work, I'm cool with the behaviour as it is.  I'll let you (Roland) and Jeff decide.  Feel free to close the bug as INVALID if that's the way you decide to go.
Comment 7 Jeff Johnston CLA 2009-11-02 16:05:27 EST
(In reply to comment #6)
> If that's how other editors and wizards work, I'm cool with the behaviour as it
> is.  I'll let you (Roland) and Jeff decide.  Feel free to close the bug as
> INVALID if that's the way you decide to go.

I am closing as INVALID.  This matches the behaviour of other tools which will still end up creating a file.