Bug 214622 - ShapeCompartmentEditPart.ConnectionRefreshMgr needs improvement
Summary: ShapeCompartmentEditPart.ConnectionRefreshMgr needs improvement
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 normal
Target Milestone: 2.0.2   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-08 10:29 EST by Alex Boyko CLA
Modified: 2008-01-09 16:49 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Boyko CLA 2008-01-08 10:29:53 EST
The refresh connection manager on the shape compartment editpart determines whether a connection, one of the ends of which is inside the shape compartment, needs to be clipped or not. Connection is clipped if its source and/or target anchor point is clipped. Therefore connection refresh manager needs to know the anchor points coordinates for a connection.

Problem.
Anchor points are calculated manually, although the connection has been laid out already and anchor points could be just read directly from the connection without any calculations. Clipped or not visible connections need to be routed, however, to determine whether they still need to be clipped. This issue leads to showing connections that need really be clipped and vice versa.
Comment 1 Alex Boyko CLA 2008-01-09 12:05:05 EST
Another problem is that connection one of the ends of which is contained within a collapsed shape compartment needs to be hidden.
Comment 2 Alex Boyko CLA 2008-01-09 16:49:51 EST
Fix committed for 2.1 M5 and 2.0.2
Comment 3 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug