Community
Participate
Working Groups
> Simon McDuff schrieb: >> "Eike Stepper" <stepper@sympedia.de> wrote in message >> news:fltnv4$ci7$2@build.eclipse.org... >> >>> Simon McDuff schrieb: >>> >>>>> If so, I'd propose a different solution: >>>>> By passing all together the values down before passing them down >>>>> separately again I'd rather pass a sort of "revisionDataFinished" event >>>>> down to the store writer. Then it's up to your store implementation to >>>>> gather all the needed infos (without updating the database) within the >>>>> separate data calls and finally do the database update in one chunk at >>>>> the end (revisionDataFinished event). >>>>> >>>>> Would that be ok? >>>>> >>>>> >>>>> >>>> Sounds goods... >>>> >>>> Right now as we read the data from the stream we call primeNewObjects. >>>> This would have to change ? Right ? Because I want to make these call >>>> after I gather all the infos. >>>> >>>> >> I don't have a problem with primeNewObjects... it is when we call it that I >> have a problem with. >> We seems to mix up serialization and processing at many places. >> >> Should not we unserialize data... and then apply changes to have a real >> transaction scope. >> Right now we do both of them at the same time. >> I would like to see a separation between two different processes. >> It is strange because we create ITransaction.. and in fact we already did >> apply some changes to the graph. >> >> If we do all modifications after reading from the stream.. it will be easier >> to manage stuff in my StoreWriter. >> >> >>> Funny that it was you who wanted to have the primeNewObject method in the >>> storage API ;-) >>> I see your problem but I don't see an easy solution for it. For all your >>> optimizations I see more and more repository responsibilities walking down >>> to the store. In the end we can spare it completely and simply pass an >>> InputStream down to the store. Just joking! >>> >>> But seriously, can you tell me, how the mapping of tempIDs and metaIDs >>> should work then? >>> >>> Regards, >>> Eike Stepper >>> ---- >>> http://wiki.eclipse.org/CDO >>> http://wiki.eclipse.org/Net4j >>>
Created attachment 86338 [details] Beta1 This is where we can do the mapping of temporary objects. Now, we need to inform the storeWriter about the context of our changes.
What I would like to see from this enhancement is really to detach CommitTransactionIndication from what does the job of applying change to the graph. Let say I received newPackages,newResources,newObjects,dirtyObjects from somewhere else... I would like to be able to re-use that code wihout having to use CommitTransactionIndication. It will be good also for our 2 phases commit enhancement.
Simon, Can this one be closed as well?
(In reply to comment #3) > Simon, Can this one be closed as well? Yes, with the latest changes.. I'm very happy!!!
cleanup
Fixed in S200804140606
Reversioned due to graduation
