Bug 214457 - The target version of 3.4 is still 3.3
Summary: The target version of 3.4 is still 3.3
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.4 M5   Edit
Assignee: Les Jones CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-01-07 04:08 EST by Les Jones CLA
Modified: 2008-02-05 15:44 EST (History)
1 user (show)

See Also:

Attachments
Patch to change to 3.4 (4.65 KB, patch)
2008-01-07 04:14 EST, Les Jones CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Les Jones CLA 2008-01-07 04:08:44 EST 
Build ID: 3.4.0 I20071213-1700

Steps To Reproduce:
TargetPlatformHelper#getTargetVersionString() is still returning 3.3 in Eclipse 3.4 M4. I'd expect that by now it should be returning 3.4.
Comment 1 Les Jones CLA 2008-01-07 04:14:46 EST 
Created attachment 86290 [details]
Patch to change to 3.4

The patch changes the returned value to 3.4 in PDE-Core. It also updates NewProjectCreationPage and NewLibraryPluginCreationPage in the PDE-UI plug-in to take account of this new default.
Comment 2 Brian Bauman CLA 2008-01-07 13:41:14 EST 
Thanks Les, let me take a look...
Comment 3 Brian Bauman CLA 2008-01-07 14:04:31 EST 
Looks great Les!  Thanks for the patch.  In the past I think adding the latest version to the wizard has been a "right of passage" we have always done, seems fitting this year too :)  

Patch applied as is (minus adding copyright comments to give you credit).
Comment 4 Brian Bauman CLA 2008-02-05 15:44:56 EST 
Verified on I20080204-0010