214156 – Quickfix to remove Bundle-Activator if there's no lazy start

Bug 214156 - Quickfix to remove Bundle-Activator if there's no lazy start

Summary: Quickfix to remove Bundle-Activator if there's no lazy start

Status:	RESOLVED FIXED

Alias:	None

Product:	PDE
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.4
Hardware:	PC Windows XP

Importance:	P3 enhancement (vote)
Target Milestone:	3.4 M5
Assignee:	bartosz michalik
QA Contact:

URL:
Whiteboard:
Keywords:	bugday, contributed

Depends on:	209432
Blocks:
	Show dependency tree

Reported:	2008-01-02 16:20 EST by Chris Aniszczyk
Modified:	2008-01-02 22:39 EST (History)
CC List:	1 user (show)

See Also:

Attachments
mylyn/context/zip (1.09 KB, application/octet-stream) 2008-01-02 18:02 EST, Chris Aniszczyk	no flags	Details
fix with separate resolution classes (12.80 KB, patch) 2008-01-02 21:19 EST, bartosz michalik	no flags	Details \| Diff
patch with single class for both quick fixes (11.10 KB, patch) 2008-01-02 21:44 EST, bartosz michalik	no flags	Details \| Diff
pde.patch (4.21 KB, patch) 2008-01-02 22:38 EST, Chris Aniszczyk	no flags	Details \| Diff
mylyn/context/zip (8.78 KB, application/octet-stream) 2008-01-02 22:39 EST, Chris Aniszczyk	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Chris Aniszczyk

2008-01-02 16:20:02 EST

This is an enhancement for part of the work in bug 209432

Comment 1 bartosz michalik

2008-01-02 17:56:02 EST

I'll take care if it's not taken

Comment 2 Chris Aniszczyk

2008-01-02 18:02:49 EST

Here's a context for your Bartosz. Look at RemoveUnknownExecEnvironments as an example.

Thanks, it should be very straightforward.

Comment 3 Chris Aniszczyk

2008-01-02 18:02:54 EST

Created attachment 86038 [details]
mylyn/context/zip

Comment 4 bartosz michalik

2008-01-02 21:19:45 EST

Created attachment 86050 [details]
fix with separate resolution classes

Comment 5 bartosz michalik

2008-01-02 21:44:59 EST

Created attachment 86053 [details]
patch with single class for both quick fixes

Comment 6 Chris Aniszczyk

2008-01-02 22:38:59 EST

Created attachment 86056 [details]
pde.patch

I decided to just use the remove resolution as the disable one was effectively the same thing.

I also got rid of the modelChangedEvent addition, that wasn't necessary. See the updated patch to learn why :)

Comment 7 Chris Aniszczyk

2008-01-02 22:39:01 EST

Created attachment 86058 [details]
mylyn/context/zip

Comment 8 Chris Aniszczyk

2008-01-02 22:39:50 EST

Thanks again Bartosz!