Bug 213730 - Properly guard against null project as parameter
Summary: Properly guard against null project as parameter
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.0 M7   Edit
Assignee: Trung CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-12-21 15:30 EST by Kathy Chan CLA
Modified: 2008-05-01 14:09 EDT (History)
0 users

See Also:

Attachments
For 'org.eclipse.jst.ws.consumption' (2.03 KB, patch)
2008-03-30 16:09 EDT, Trung CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kathy Chan CLA 2007-12-21 15:30:00 EST 
FacetUtils.isJavaProject() could cause NPE if the input project is null.  We should properly guard against this.
Comment 1 Kathy Chan CLA 2008-02-15 13:48:16 EST 
Please add null checks for other methods in FacetUtils when the input should not be null.
Comment 2 Trung CLA 2008-03-30 16:09:06 EDT 
Created attachment 94149 [details]
For 'org.eclipse.jst.ws.consumption'

Add null checking for all methods that return boolean value.
I didn't read all other methods in the class. There are 30+ of them and it's not very obvious how to deal with these in case input is null.
I think it's probably not worth it.
Comment 3 Kathy Chan CLA 2008-04-29 23:36:30 EDT 
Patch released to HEAD as v200804300334.
Comment 4 Kathy Chan CLA 2008-05-01 14:09:18 EDT 
Closing.