Bug 213186 - big patch for js codecompletion fixes and improvements.
Summary: big patch for js codecompletion fixes and improvements.
Status: RESOLVED FIXED
Alias: None
Product: DLTK
Classification: Technology
Component: JavaScript (show other bugs)
Version: 0.95   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: dltk.common-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-12-17 10:52 EST by Johan Compagner CLA
Modified: 2010-06-11 07:00 EDT (History)
1 user (show)

See Also:


Attachments
the patch (24.10 KB, patch)
2007-12-17 10:53 EST, Johan Compagner CLA
alex.panchenko: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Compagner CLA 2007-12-17 10:52:31 EST
here all the changes:

new interface: IProposalHolder 
IDesignTimeDOMProvider uses that interface now to get for a specific key the param names and the doc.
  Also added 1 extra method so that the IDesignTimeDomProvider can filter/resolve the ids from a specific Scriptable.
DOMResolver: use Scriptable where over possible instead of ScriptableObject (interface before impl)
  Also walk over the parents instead only over the prototype else you will never get the complete tree that can be used.
  use the IProposalHolder to set params and doc into the UncknownReference object.
SampleProvider: updated to the new changes in the IDesignTimeDOMProvider interface.


ScriptCompletionEngine: Change for support to get parameternames and proposalInfo's (doc)
CompletionProposal: Fix for if it is a METHOD_REF that then parameters names can be in the proposal.
UncknownReference: parameterNames/proposalInfo fields and get/setters.
JavaScriptCompletionEngine: Change for support to get parameternames and proposalInfo's (doc)

JavaScriptCompletionProposalCollector: support that proposal can be just a string.
ScriptMethodCompletionProposal: support for params and linked mode so you can tab over the param names.


With this implementation we could do pretty much everything we want, have parameter names and doc in the code completion. And i only have to build 1 domprovider needed for the complete code completion tree. Because it also walks over the parents.

If you have any question about this patch or reservations please ping me.
Comment 1 Johan Compagner CLA 2007-12-17 10:53:05 EST
Created attachment 85388 [details]
the patch
Comment 2 Andrei Sobolev CLA 2007-12-18 01:29:24 EST
Applied.
Comment 3 Andrey Platov CLA 2008-05-26 02:48:55 EDT
bulk change: fixed in 0.95