Bug 213176 - CompletonProposalComparator patch
Summary: CompletonProposalComparator patch
Status: RESOLVED FIXED
Alias: None
Product: DLTK
Classification: Technology
Component: JavaScript (show other bugs)
Version: 0.95   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: dltk.common-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-12-17 09:58 EST by Johan Compagner CLA
Modified: 2010-06-11 07:33 EDT (History)
1 user (show)

See Also:


Attachments
The patch (1.01 KB, patch)
2007-12-17 09:59 EST, Johan Compagner CLA
alex.panchenko: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Compagner CLA 2007-12-17 09:58:28 EST
this piece of code sometimes results in a nullpointer somewhere else:

	private String getSortKey(ICompletionProposal p) {
		if (p instanceof AbstractScriptCompletionProposal)
			return ((AbstractScriptCompletionProposal) p).getSortString();
		return p.getDisplayString();
	}
because getSortString() can return null. I made a patch so that then it still fallsback to display string.
Comment 1 Johan Compagner CLA 2007-12-17 09:59:08 EST
Created attachment 85380 [details]
The patch
Comment 2 Andrei Sobolev CLA 2007-12-18 01:15:02 EST
Applied.
Comment 3 Andrei Sobolev CLA 2007-12-18 01:17:09 EST
Closing.
Comment 4 Andrey Platov CLA 2008-05-26 02:48:52 EDT
bulk change: fixed in 0.95