Community
Participate
Working Groups
I20071212-0010. See bug 185502 for details. The dialog that's now shown has three issues: - it should be a warning dialog - dialogs should use title casing i.e. start words with big letters - it says: ... plug-ins my not be... (my -> may) - the message talks about 'workbench' but actually it can be anything that runs eclipse code (e.g. a simple SWT app). How about this: title: Running Application message: An application is currently running. Some of the selected plug-ins may not be imported if they are locked by it. Do you want to continue? If more than one app is running it has to be changed to: title: Running Applications message: Applications are currently running. Some of the selected plug-ins may not be imported if they are locked by one of them. Do you want to continue?
Bartosz volunteered to take this one.
Created attachment 85093 [details] simple fix
Thanks Bartosz for the quick fix. The patch was applied as is and made it into I20071212-1300.
Looked at the fix in I20071212-1800: this is a good improvement and good enough for M4 but a UI guideline in eclipse is to use singular and plural correctly i.e. you have to check whether there is 0, 1 or more apps running and show the appropriate message. You should either reopen this bug and target for M5 or file a new one.
Dani, I will take your word for it about the singular/plural rule because I did not find it on the Eclipse UI Guidelines wiki :) The messages should be updated in HEAD now to reflect one vs. multiple runtimes.
Thanks.
