Bug 212599 - [search] fine grained search must not report matches in Javadoc
Summary: [search] fine grained search must not report matches in Javadoc
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-11 11:29 EST by Dani Megert CLA
Modified: 2007-12-13 04:30 EST (History)
4 users (show)

See Also:

Attachments
Proposed patch (4.38 KB, patch)
2007-12-11 12:51 EST, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2007-12-11 11:29:48 EST 
I20071211-0010.

Fine grained search reports unexpected matches in Javadoc.

Test Case:
1. import source for 'org.eclipse.core.filebuffers'
2. search for type IFile where used as method return type
==> reports stuff in Javadoc
Comment 1 Frederic Fusier CLA 2007-12-11 12:51:22 EST 
Created attachment 84990 [details]
Proposed patch

The patch is really simple and safe: do not report any references inside Javadoc comments as soon as a fine grain flag is set...

I think we can add this fix for 3.4M4...
Comment 2 Frederic Fusier CLA 2007-12-11 12:52:16 EST 
Jerome, do you agree to put this fix into 3.4M4?
Comment 3 Jerome Lanneluc CLA 2007-12-12 04:23:43 EST 
+1 for 3.4M4
Comment 4 Frederic Fusier CLA 2007-12-12 04:35:09 EST 
Released for 3.4M4 in HEAD stream.
Comment 5 David Audel CLA 2007-12-13 04:30:59 EST 
Verified for 3.4M4 using build I20071212-1800.