Bug 212315 - Flowfigures should pass the fragment that's being painted to the FlowBorder
Summary: Flowfigures should pass the fragment that's being painted to the FlowBorder
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy Draw2d (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-07 19:36 EST by Pratik Shah CLA
Modified: 2014-07-12 05:50 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Shah CLA 2007-12-07 19:36:50 EST 
That greatly increases the potential of what the FlowBorder can do since it would have access to things such as the fragment's baseline (useful for underline borders).

Assigning to myself.
Comment 1 Anthony Hunter CLA 2008-02-08 15:32:55 EST 
Missed M5, so moving to M6
Comment 2 Anthony Hunter CLA 2008-03-31 12:03:43 EDT 
Not sure if this is going to make API freeze (is this API?).
Comment 3 Pratik Shah CLA 2008-04-01 11:19:20 EDT 
Yes, it is.  When's the API freeze, Anthony?  We could add this to just AbstractFlowBorder (instead of FlowBorder) and then it would just be an API addition.  Alternatively, perhaps exposing the fragments on all figures is the right way to go (I'd have to explore a bit to see if it satisfies all my needs).
Comment 4 Anthony Hunter CLA 2008-04-01 11:51:40 EDT 
API freeze is M6 (March 31). 

I have no issue with adding API that cannot break anyone to solve a issue.
Comment 5 Pratik Shah CLA 2008-04-07 23:07:18 EDT 
Adding that method to AbstractBorder would satisfy my needs, but there's probably other information that might also be useful.  The code around flow borders is not very robust anyways.  There are a lot of things that need to be fixed in this area in general, and I'll tackle them when I have made more use of the borders and have a better understanding of what all it needs to support.  Since the suggested API change is not critical for us, I'll defer this for now.
Comment 6 Alexander Nyßen CLA 2013-10-17 09:50:00 EDT 
Assigning back to gef-inbox (and state to new), as specified assignee is no current GEF committer.