Bug 212178 - GMF validation enhancements
Summary: GMF validation enhancements
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 enhancement
Target Milestone: 2.1   Edit
Assignee: James Bruck CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 196187 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-12-06 13:53 EST by James Bruck CLA
Modified: 2010-07-19 21:55 EDT (History)
3 users (show)

See Also:

Attachments
Please consider this first attempt. Let me know of any issues. (23.05 KB, patch)
2007-12-06 13:57 EST, James Bruck CLA 		no flags Details | Diff
Updated patch. (24.38 KB, patch)
2007-12-10 16:28 EST, James Bruck CLA 		ahunter.eclipse: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Bruck CLA 2007-12-06 13:53:45 EST 
GMF's UIFileModificationValidator could be enhanced to perform time stamp checking.  This would help with scenarios involving clear case and using dynamic views where two people have views on the same file.

Additionally, the UIModificationValidator could execute validations in a thread safe manner and prevent deadlocks if a particular transaction invokes a UI.

Commands causing file updates as a side effect of executing the command might require file validation at the commit stage before the transaction finishes.  I would propose registering the UIModificationValidator so that it would be invoked at commit time.  EMF's enhanced transaction API allows for custom validators to perform validation at the commit() stage.
Comment 1 James Bruck CLA 2007-12-06 13:57:49 EST 
Created attachment 84659 [details]
Please consider this first attempt.   Let me know of any issues.
Comment 2 James Bruck CLA 2007-12-10 16:28:22 EST 
Created attachment 84901 [details]
Updated patch.
Comment 3 Anthony Hunter CLA 2007-12-19 16:33:35 EST 
*** Bug 196187 has been marked as a duplicate of this bug. ***
Comment 4 Anthony Hunter CLA 2008-01-28 11:32:13 EST 
Hi Linda, can you commit this patch to HEAD? (change updated in header to 2008).
Comment 5 Linda Damus CLA 2008-02-08 16:47:22 EST 
Reviewed and committed the patch with some minor changes:

- updated copyrights
- fixed a little bit of javadoc
- updated the plug-in versions to reflect the non-breaking API changes.  

Also ran the following JUnit tests:

org.eclipse.gmf.tests.runtime.common.core: 45/45 passed
org.eclipse.gmf.tests.runtime.common.ui: 23/23 passed
Comment 6 Richard Gronback CLA 2008-08-13 13:08:53 EDT 
[target cleanup] 2.1 M5 was the original target milestone for this bug
Comment 7 Eclipse Webmaster CLA 2010-07-19 21:55:51 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Common was the original product and component for this bug