Bug 211810 - [prov] should rollback repo be a registered service?
Summary: [prov] should rollback repo be a registered service?
Status: RESOLVED WORKSFORME
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Incubator (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: equinox.incubator-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2007-12-03 15:24 EST by Susan McCourt CLA
Modified: 2008-01-04 13:20 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2007-12-03 15:24:47 EST
There needs to be some public API way to get the rollback repo (so that the revert UI can show the various saved profiles).

For now, I simply promoted getRollbackLocation() to IDirector API and made it public in SimpleDirector.  We might want to do something nicer later.
Comment 1 Jeff McAffer CLA 2007-12-03 21:11:09 EST
An interesting thing that has been lurking in the back of my mind is making all the repo into services...

Didn't mean to broaden this particular bug but it feels strange to call out one in particular.
Comment 2 Pascal Rapicault CLA 2007-12-04 09:43:25 EST
I was thinking about this when we first talked about the idea. However it seems that this would go against the API changes John are working on in the repository manager area.
The other approach we could take to make the repo available is to publish well known keys for some repositories.
Comment 3 John Arthorne CLA 2007-12-04 11:17:37 EST
It needn't be the actual IMetadataRepository object registered as a service, because that would prevent us from discarding the large repository objects when not in use. However, we could instead register a service object capable of returning a repository, or providing a repository location. In fact, we could just register an instance of the Location service for each repository and publish the service filter in API.
Comment 4 John Arthorne CLA 2008-01-04 13:20:20 EST
Leave as it is for now. This is consistent with the other repository locations we make available on AgentLocation.  There is an API method for obtaining the repository location, but the actual repository object is still obtained via a service call.