Description kate_glickman 2007-11-30 11:07:04 EST

Created attachment 84189 [details]
patch to BuildScriptGenerator

Build ID:  M20071023-1652

Steps To Reproduce:
1. In the build.properties, set configs to something besides *.*.*
2. Set groupConfigurations=true
3. Set archivesFormat to be folder for each of the configurations.

When you build, the archive will be a zip instead of a folder.


More information:

I debugged into it and found that the reason it doesn't work is because the configuration passed into BuildScriptGenerator.realSetArchivesFormat() is always (group, group, group), which doesn't match any of my real configs.  

So, I tried setting the archiveFormat to group,group,group.  This didn't work either because it checks to see if it's a valid config before adding it to the archivesFormat table.

Then I tried adding group,group,group as a config as well but I got a message saying something about duplicate root_files.

Finally, I made a patch allowing an archiveFormat of group,group,group if groupConfigurations is true.  That works fine, though I don't know if that's the approach you'd like to take.  If you use the patch, you need to be sure to add a comment in the build.properties about needing to specify group,group,group as an archivesFormat if groupConfigurations=true.