Bug 211580 - [spy] provide a 'x' in the top right corner to close the view
Summary: [spy] provide a 'x' in the top right corner to close the view
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-11-30 06:20 EST by Chris Aniszczyk CLA
Modified: 2007-12-11 12:31 EST (History)
3 users (show)

See Also:
baumanbr: review? (caniszczyk)

Attachments
Proposed patch - Adds a "close" button to the form heading of the spy dialog (5.02 KB, patch)
2007-11-30 10:27 EST, Benjamin Cabé CLA 		no flags Details | Diff
Close icon (351 bytes, image/gif)
2007-11-30 11:36 EST, Benjamin Cabé CLA 		no flags Details
Adds a "close" button to the form heading of the spy dialog (3.85 KB, patch)
2007-11-30 13:18 EST, Benjamin Cabé CLA 		no flags Details | Diff
mylyn/context/zip (2.21 KB, application/octet-stream)
2007-12-01 04:37 EST, Chris Aniszczyk CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2007-11-30 06:20:41 EST 
Currently, the spy view lacks a way to close it via a UI decoration. It should have a little 'x' in the top right corner.
Comment 1 Benjamin Cabé CLA 2007-11-30 09:23:31 EST 
I take it for today's bugday !
Comment 2 Benjamin Cabé CLA 2007-11-30 10:27:38 EST 
Created attachment 84182 [details]
Proposed patch - Adds a "close" button to the form heading of the spy dialog

I'm not really sure that the "binary" GIF included in the patch will be OK ... Just tell me if something's wrong !
Comment 3 Brian Bauman CLA 2007-11-30 11:14:35 EST 
Benjamin, could you attach the gif file directly to the bug report.  The patch framework doesn't like image files :)
Comment 4 Brian Bauman CLA 2007-11-30 11:22:44 EST 
Chris, since PDE Spy is your baby, I will wait for you to review this.  Should not be too long to review.

I did a quick test and everything seemed to be in order, good job Benjamin!
Comment 5 Benjamin Cabé CLA 2007-11-30 11:36:47 EST 
Created attachment 84194 [details]
Close icon

In fact, you'll easily notice it's the standard "Delete" icon (IMG_OBJ_DELETE of ISharedImages) ... IMHO, it has a pretty nice look&feel for a form close button, but I think it's better to copy/paste it into PDE icons folder just because the red cross of IMG_OBJ_DELETE can be changed in further releases, and become something like a trashcan or something like that ;-)
Comment 6 Remy Suen CLA 2007-11-30 12:40:48 EST 
(In reply to comment #5)
> In fact, you'll easily notice it's the standard "Delete" icon (IMG_OBJ_DELETE
> of ISharedImages) ... IMHO, it has a pretty nice look&feel for a form close
> button, but I think it's better to copy/paste it into PDE icons folder just
> because the red cross of IMG_OBJ_DELETE can be changed in further releases, and
> become something like a trashcan or something like that ;-)

I don't know about that. I think it's better to just use the platform's shared images instead of copying it over unnecessarily. If it ever gets changed, it can be copied over then, but I don't really see any reason to do this now.
Comment 7 Benjamin Cabé CLA 2007-11-30 13:18:59 EST 
Created attachment 84208 [details]
Adds a "close" button to the form heading of the spy dialog

Uses ISharedImages.IMG_TOOL_DELETE instead of a copied icon.
Comment 8 Chris Aniszczyk CLA 2007-12-01 04:37:55 EST 
Thanks for the simple and elegant patch Benjamin.
Comment 9 Chris Aniszczyk CLA 2007-12-01 04:37:59 EST 
Created attachment 84257 [details]
mylyn/context/zip
Comment 10 Brian Bauman CLA 2007-12-11 12:31:36 EST 
verified on I20071211-0010