Bug 211418 - Handling % in svn+ssh URLs
Summary: Handling % in svn+ssh URLs
Status: RESOLVED FIXED
Alias: None
Product: Subversive
Classification: Technology
Component: Core (show other bugs)
Version: 0.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Alexander Gurov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 211257 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-11-29 04:33 EST by Alexander Gurov CLA
Modified: 2011-05-18 06:39 EDT (History)
0 users

See Also:


Attachments
Maybe a problem fix. (1.60 KB, patch)
2007-11-30 12:14 EST, Alexei Goncharov CLA
i.vinnykov: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Gurov CLA 2007-11-29 04:33:57 EST
I have an account at mediatemple.net where subversion is accessible only via svn+ssh. Due to the shared hosting environment, the usernames at mediatemple-hosted domains contain a percent sign (and the virtual domain name, in case the following URL is confusing to look at...the actual username is "myuser%mydomain.com"). Thus the svn+ssh URL becomes: 

svn+ssh://myuser%mydomain.com@mydomain.com/home/accountnum/users/myuser%mydomain.com/svn 

On some systems (Windows), to make SVN GUI clients work you must replace the % with %25, and on others (unix) you don't have to do this. 

This style URL works fine from Subclipse on Mac OS X (without using the %25 approach at all), but Subversive on Mac chokes with both % and %25 style URLs. 

When defining a repository with %25 approach, Subversive appears to work in some cases (connecting to the repository when doing "finish" connection validation...sort of...not without errors), but subsequently chokes trying to actually share resources into the SVN server and/or check them out. In fact, the repository setup dialog seems to require use of %25 in the URL, but then it seems to have replaced these with just a % sign upon re-opening the repository properties dialog. 

It would seem that Subversive may be overly aggressive in replacing the %25 in the persisted repository preferences, paired with not allowing a plain % sign to work in the non-path (username) portion of the URL in the first place. 

The following URL contains some discussion of the problem, but is not entirely accurate: 

http://www.breakitdownblog.com/2007/05/14/using-mediatemples-subversion-svnssh-with-eclipse

Scott Riggins
Comment 1 Alexei Goncharov CLA 2007-11-30 12:14:45 EST
Created attachment 84204 [details]
Maybe a problem fix.

As I think the problem is that the percent sign is a part of a username, but not URL, so it should never be neither encoded nor decoded.

The patch is provided. Hope it should fix the described problem.
Comment 2 Alexander Gurov CLA 2007-12-04 09:56:14 EST
*** Bug 211257 has been marked as a duplicate of this bug. ***
Comment 3 Alexander Gurov CLA 2007-12-04 10:11:02 EST
Thank you for the provided patch. If the problem persists please reopen this report.