Community
Participate
Working Groups
PluginVersionPart and DependencyPropertiesDialog are in need of a rewrite. Right now, they are written in a very non-object oriented way and are very hard to extend. PluginVersionPart should be refactored out into an AbstractVersionPart and have at least three extenders, PluginVersionPart, PackageVersionPart, FragmentVersionPart. A lot of the logic in DependencyPropertiesDialog should belong in the parts as they construct themselves... too much "business logic" in the dialog currently.
Chris, Quick query - I can certainly see why this needs doing, but why Plugin/Package/Fragment -VersionPart? From the quick skim I've done, it would appear that three candidate concrete classes could be Plugin/PackageImport/PackageExport -VersionPart. I'm not sure I can see how fragments would be involved? Am I missing something obvious?
I was... and I've now found it :-)
Seems to me from the quick look I've had that there should be a new VersionPart class containing the min/max (or single value) fields, which can be used in all the relevant scenarios, but which doesn't need to be subclassed. This can be used directly by FragmentContentPage and indirectly by the DependencyPropertiesDialog. There should also remain the Plugin/PackageImport/PackageExport -VersionPart classes (with a common base class). These will taking some of the logic away from the DependencyPropertiesDialog as well as using the VersionPart class if required. Doing this should simplify the classes quite a lot, as well as allowing the new VersionPart to become ever more consumable - e.g. as part of FragmentGeneralInfoSection.
That sounds pretty much what I had in mind Les. As currently, things are messy and there's too much logic in the dependency dialog :)
btw, lmk if you want this one :)
Yup, you can assign it to me. It probably won't be resolved in the next few days though.
> Yup, you can assign it to me. It probably won't be resolved in the next few > days though. Not to worry, we aren't in a rush :)
Probably a good job with this beast ;-)
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Please remove the stalebug flag, if this issue is still relevant and can be reproduced on the latest release.
