Bug 210543 - [formatter] Thin regression in JDT/Core formatter performance test
Summary: [formatter] Thin regression in JDT/Core formatter performance test
Status: VERIFIED WORKSFORME
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Eric Jodet CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance, test
Depends on:
Blocks:
 
Reported: 2007-11-21 11:27 EST by Frederic Fusier CLA
Modified: 2008-07-07 12:26 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2007-11-21 11:27:45 EST
After having run JDT/Core perf tests on our local Linux test box, I noticed a thin regression on FullSourceWorkspaceFormatterTests.testFormatDefault() test.

Here are the numbers for this test:
M1	0.36%
M2	0.28%
v_815	0.37%
v_816	0.40%
v_817	0.09%
v_818	-0.21%
v_819	0.05%
v_820	0.17%
v_821	-0.00%
M3	-1.79%
v_823	-1.80%
v_824	-2.88%
v_825	-2.36%

These numbers are the average of 20 runs (except for v_825 - only 8 - as tests are currently running for this version) and each run has a standard error around 1%. So, it seems that a change between v_821 & v_822 made the formatter a little bit smaller and should be investigated...

Note that, depending on the test box, this test lasts between 1 second and 1.5 second. So, this regression should not be noticeable by users. Honestly, it was impossible to see it on Platform/Releng perf results as it was run only once per build... That's why I opened this bug with a 'minor' priority'.
Comment 1 Frederic Fusier CLA 2007-11-21 11:30:47 EST
Looking at difference between those two JDT/Core versions, it looks like the fix for bug 203304 may be responsible of this regression...
Comment 2 Olivier Thomann CLA 2007-11-21 11:36:11 EST
Not a surprise.
This change is required to fix some other performance issues, but it penalizes a little the case where there is only one region.
Comment 3 Frederic Fusier CLA 2008-07-07 12:25:28 EDT
This regression was fixed while activating the new comment formatter in 3.4M7...
Comment 4 Frederic Fusier CLA 2008-07-07 12:26:56 EDT
Looking at 3.4M7 performance resutls, there's now a gain between +1.8% and +5.0%