Bug 210431 - org.apache.batik.pdf does not declare imported packages properly.
Summary: org.apache.batik.pdf does not declare imported packages properly.
Status: RESOLVED FIXED
Alias: None
Product: Orbit
Classification: Tools
Component: bundles (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 212024
  Show dependency tree
 
Reported: 2007-11-20 13:15 EST by James Bruck CLA
Modified: 2008-01-08 10:42 EST (History)
3 users (show)

See Also:


Attachments
updated manifest for batik.pdf (1.17 KB, patch)
2007-11-20 13:15 EST, James Bruck CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Bruck CLA 2007-11-20 13:15:01 EST
Created attachment 83347 [details]
updated manifest for batik.pdf

I am trying to use the PDFTranscoder and although it compiles as is, I get NoClassDefExceptions during runtime.

I attached a patch that add necessary import declarations.
Comment 1 Chris Aniszczyk CLA 2007-11-20 17:12:52 EST
I'll get this in
Comment 2 Chris Aniszczyk CLA 2007-11-20 17:26:03 EST
thanks for the patch. I also set a BREE since I noticed we were missing one.
Comment 3 David Williams CLA 2007-11-20 23:35:32 EST
Note that the most recent changes here caused a build break. 

The reason being that JavaSE-1.4 is not a recognized EE. 
I assume you meant "J2SE-1.4" instead? 

Also, I noticed you changed the HEAD version of this bundle. 

There should not be a HEAD version at all. 

There is a 1.6 branch, which I assume is the proper branch. I suggest someone "in the know" compare the two, and make sure the 1.6 branch is accurate, and if so, make the changes there, and then delete the HEAD content, leaving only the usual simple project .project file and the usual readme with pointers to the branches. This deletion would help avoid similar errors in the future. 

A more minor issue, I noticed in the modified version that the 'legal' directory was exported. This is a PDE bug that it includes these non-code directories in it's cleanup wizards, but I believe in general we go in and remove them "by hand" when they are obviously non-code. 

Thanks, 



Comment 4 Chris Aniszczyk CLA 2007-11-21 22:04:39 EST
Thanks for the catch David. That's what I get for trying to be nice and doing something quickly before leaving on vacation :)

I cleaned out the HEAD version. Also updated the branch 1.6 version with the proper MANIFEST.MF and BREE.
Comment 5 James Bruck CLA 2007-11-22 09:33:58 EST
Thanks for getting this in quickly !  Much appreciated.
Comment 6 Anthony Hunter CLA 2008-01-08 10:42:08 EST
Do you know when a build with this fix will be available?

The fix is not tagged in CVS yet.