Bug 210333 - Improve Extensibility of the Connection Profile UI Framework
Summary: Improve Extensibility of the Connection Profile UI Framework
Status: CLOSED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: Connectivity (show other bugs)
Version: 1.6   Edit
Hardware: PC Windows 2000
: P3 enhancement (vote)
Target Milestone: 1.6M4   Edit
Assignee: Linda Chan CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 212257
  Show dependency tree
 
Reported: 2007-11-19 22:45 EST by Linda Chan CLA
Modified: 2008-07-01 17:41 EDT (History)
1 user (show)

See Also:
ledunnel: review+


Attachments
Patch for the proposed enhancements (6.57 KB, text/plain)
2007-11-19 22:47 EST, Linda Chan CLA
no flags Details
Additional enhancements. (24.41 KB, text/plain)
2007-12-07 07:44 EST, Linda Chan CLA
no flags Details
Further refactoring of running TestConnection (3.70 KB, patch)
2007-12-10 22:41 EST, Linda Chan CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Linda Chan CLA 2007-11-19 22:45:38 EST
Improve the extensibility of the Connectivity UI framework from an adopter's perspective, below are some enhancements: 

Additional API methods in o.e.d.connnectivity.ui.NewConnectionProfileWizard class to allow a consumer application to:
*  specify its own performFinish() behavior 
*  assign the name of a profile instance without user input in the NewConnectionProfileWizardPage

In the o.e.d.connectivity.ui ConnectionProfile property pages:
*  change ProfilePropertyPage.getConnectionProfile() from a protected to public method 
    The inherited getElement() is already a public method.  It should be fine to make this specialized element a publicly accessible one as well. 

*  enhance the implementation of ProfileDetailsPropertyPage.setPingButtonEnabled method to ensure the button is truely enabled, if it is buried deep in composites.
Comment 1 Linda Chan CLA 2007-11-19 22:47:37 EST
Created attachment 83297 [details]
Patch for the proposed enhancements
Comment 2 Linda Chan CLA 2007-11-19 23:02:43 EST
Committed the patch, which is reviewed and approved by 2 other committers: Larry Dunnell and Brian Fitzpatrick.

Comment 3 Linda Chan CLA 2007-12-07 07:42:09 EST
More enhancements to improve the CP UI extensibility are added (see the second patch file).  They mainly involves extracting base class implementation into granular methods to allow adopters to extend the base class behavior:

* extend the UI design of the ExportProfilesDialog
* extend the ExportProfileViewAction to run without being associated with a view
* run a new profile's TestConnection task without using an async Job (in ConnectionProfileDetailsPage and PingJob classes)

Comment 4 Linda Chan CLA 2007-12-07 07:44:55 EST
Created attachment 84721 [details]
Additional enhancements.
Comment 5 Linda Chan CLA 2007-12-07 17:35:05 EST
Committed the additional enhancements.
Comment 6 Linda Chan CLA 2007-12-10 22:41:40 EST
Created attachment 84923 [details]
Further refactoring of running TestConnection 

Refactors the TestConnection runnable creation method (o.e.d.connectivity.ui.wizards.ConnectionProfileDetailsPage) to use the IConnectionProfile interface as its argument, instead of the internal implementation class.  
Also applies similar method extraction in the UI page that edits an existing connection profile (o.e.d.connectivity.ui.wizards.ProfileDetailsPropertyPage).
Comment 7 Linda Chan CLA 2007-12-10 22:50:23 EST
Committed above patch.
Comment 8 Brian Fitzpatrick CLA 2008-07-01 17:41:43 EDT
Closing bugs