Bug 21010 - Use getAdapter when converting IJavaThread to JDIThread
Summary: Use getAdapter when converting IJavaThread to JDIThread
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: Jared Burns CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-06-26 10:37 EDT by Erin Harris CLA
Modified: 2002-07-23 15:42 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erin Harris CLA 2002-06-26 10:37:54 EDT 
In JDT when converting IJava* to JDI* use getAdapter instead of casting.

For example in JDIClassType it casts an IJavaThread to a JDIThread.

Or some other method for allowing super debug adapters to inherit the features 
of JDT debug adapter.
Comment 1 Darin Swanson CLA 2002-06-27 10:53:37 EDT 
Deferred for post 2.0 consideration
Comment 2 Jared Burns CLA 2002-07-01 14:53:41 EDT 
The IJava* interfaces are not allowed to be implemented. Thus, JDIThread is 
guaranteed to be the only implementation of IJavaThread. If a client 
implements IJavaThread, they are breaking the rules of engagement.

Move to close.
Comment 3 Darin Wright CLA 2002-07-23 14:33:04 EDT 
Erin identified minimal fixes required for 2.0.1 as 

(1) implement #getAdapter(IJavaThread) in JDIThread
(2) Chnages to ThreadFilterViewer to use IJavaThread/IJavaDeubgTarget adapaters
Comment 4 Darin Wright CLA 2002-07-23 14:38:32 EDT 
If we use #getAdapter calls, clients do not have to implement the java debug 
model interfaces. We should investigate a more full blown implementation of 
this. I will open a new bug for further work.

Fix released to HEAD and 2.0.1 branch.
Comment 5 Darin Wright CLA 2002-07-23 14:38:48 EDT 
Please verify, Jared.
Comment 6 Jared Burns CLA 2002-07-23 15:42:12 EDT 
Verified code.