Community
Participate
Working Groups
Currently, the spy does image scraping to save images found in editors and views. The use of ImageLoader to save images isn't the right approach here because we lose things like transparency and original name of the image. We should be able to query for the image using the extension registry and get the acutal image we need and copy that to where the user would like to save it.
Created attachment 84260 [details] Using Part's ImageDescriptors instead of their Images is enough to the trick :) I've fixed that bug retrieving Editor and Views ImageDescriptors respectively through EditorRegistry and ViewRegistry
...to *do* the trick
Thanks Benjamin, I'll take a look at this next week. I had some of this bug solved in my workspace but your patch is much smaller and elegant than mine :) I went directly to the extension registry for information so I can just do a simple image copy from what's in the plug-in.
Created attachment 86360 [details] patch updated for HEAD
Please find attached a patch updated for HEAD. Chris, I'm afraid you forgot to run "organize imports" when you recently switched to new code conventions :-s
That would be nice if you could have a look at the patch, chris :-) If you have time enough, of course!..
Chris, I know you're not ignoring me, no problem! Can you please assign me that one, tag it as contributed, and probably target it for M7! :)
I'm not completely happy with the patch and I will tell you why once I remember. we should be going to the ext registry and finding the url for the icon and then copying them out... at least that's what my fuzzy memory recalls ;)
moving to 3.5... I'm not happy with the current solution and removing the functionality for the 3.4 release due to time. The ideal solution is to actually query the extension registry and copy the file from the registry representing the image. We will investigate later, the Plug-in Spy is good enough for 3.4 at the moment :) Thanks for your help Benjamin and sorry for not being able to get this in for 3.4
oops, messed up the subject ;o
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
This bug has been marked as stalebug a while ago without any further interaction. If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard flag.
This bug was marked as stalebug a while ago. Marking as worksforme. If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard tag.
