Bug 209993 - [1.5][search] Generic search does not get correctly type arguments from BindingKey
Summary: [1.5][search] Generic search does not get correctly type arguments from Bindi...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 209475
Blocks:
  Show dependency tree
 
Reported: 2007-11-15 11:59 EST by Frederic Fusier CLA
Modified: 2007-12-12 09:53 EST (History)
1 user (show)

See Also:

Attachments
Proposed patch (11.04 KB, patch)
2007-12-07 09:20 EST, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2007-11-15 11:59:18 EST 
Follow-up of bug 209475 where generic search tests were modified to pass after having fixed the BindingKey behavior.

In fact the initial failures noticed with this fix show that the Generic Search is not working properly in certain circumstances. This must be fixed for 3.4
Comment 1 Frederic Fusier CLA 2007-12-07 09:20:37 EST 
Created attachment 84733 [details]
Proposed patch

The fix uses now the correct BindingKey methods - typically isParameterizedType() while looking for type arguments of the method declaring type.
Comment 2 Frederic Fusier CLA 2007-12-07 09:29:11 EST 
Note that, in fact, Search Engine did work properly. The real problem was the way it got the type arguments of parameterized types and methods from the BindingKey. This was only shown when bug 209475 was fixed and of course that's needed to be also fixed. I've changed the summary to reflect this.

No test cases were added as I considered that there are enough generic search tests to assume that Search Engine is still working well after this change...

Released for 3.4M4 in HEAD stream.
Comment 3 David Audel CLA 2007-12-12 09:53:51 EST 
Verified for 3.4M4 using build I20071210-1800.