Bug 209709 - CompositeTransactionalCommand#reduce should flatten child commands if !isTransactionNestingEnabled()
Summary: CompositeTransactionalCommand#reduce should flatten child commands if !isTran...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.0.1   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 2.0.2   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-11-13 16:27 EST by Christian Vogt CLA
Modified: 2010-07-19 12:24 EDT (History)
1 user (show)

See Also:

Attachments
patch for CompositeTransactionalCommand (2.87 KB, patch)
2007-11-13 16:27 EST, Christian Vogt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Vogt CLA 2007-11-13 16:27:57 EST 
Created attachment 82806 [details]
patch for CompositeTransactionalCommand

I have attached a patch for the CompositeTransactionalCommand which adds some logic to the reduce() method which will flatten out the child commands recursively if !isTransactionNestingEnabled(). Flattening large command structures prior to executing yields good performance improvements.
Comment 1 Anthony Hunter CLA 2007-11-16 10:41:44 EST 
Hi Alex, can you review and commit to R2_0_maintenance if acceptable?
Comment 2 Alex Boyko CLA 2007-11-21 16:22:21 EST 
Committed the patch to R2_0_maintenance and HEAD
Comment 3 Eclipse Webmaster CLA 2010-07-19 12:24:48 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime EMF was the original product and component for this bug