Bug 209611 - [organize imports] Organize imports perf test has no loop and no warm up
Summary: [organize imports] Organize imports perf test has no loop and no warm up
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on: 245693
Blocks:
  Show dependency tree
 
Reported: 2007-11-13 04:53 EST by Benno Baumgartner CLA
Modified: 2008-10-16 11:05 EDT (History)
2 users (show)

See Also:

Attachments
fix head (1.61 KB, patch)
2007-11-13 04:58 EST, Benno Baumgartner CLA 		no flags Details | Diff
fix perf stream (1.69 KB, text/plain)
2007-11-13 04:59 EST, Benno Baumgartner CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benno Baumgartner CLA 2007-11-13 04:53:09 EST 
I20071107-1300

The OrganizeImportsPerfTest has no loop and no warm up, which makes the test unreliable. Also we use clean up to run Organize imports in the UI since a while (bug 181160). We should therefore also test this real world scenario.
Comment 1 Benno Baumgartner CLA 2007-11-13 04:58:28 EST 
Created attachment 82741 [details]
fix head
Comment 2 Benno Baumgartner CLA 2007-11-13 04:59:44 EST 
Created attachment 82742 [details]
fix perf stream
Comment 3 Benno Baumgartner CLA 2007-11-13 05:02:28 EST 
fixed in HEAD and perf stream
Comment 4 Benno Baumgartner CLA 2007-11-13 06:08:38 EST 
Sorry, this was not really clear, this is not fixed in the sense that the existing test is fixed. But I've added a new test which should replace the existing test later in the fingerprint. I don't want to touch the exiting one until we know what's going on in bug 206013
Comment 5 Benno Baumgartner CLA 2007-12-10 07:50:18 EST 
I don't know what to do here. I opt to switch to new test once the new one is not yellow anymore (bug 212388)
Comment 6 Benno Baumgartner CLA 2008-07-16 10:18:15 EDT 
Marking as wontfix then, workaround is to use to the new test (the clean up test) which has a warm up and a loop.
Comment 7 Dani Megert CLA 2008-07-16 12:26:58 EDT 
Should delete the bogus test.
Comment 8 Dani Megert CLA 2008-07-17 04:19:41 EDT 
>Should delete the bogus test.
Or even better: just fix it!
Comment 9 Dani Megert CLA 2008-09-12 11:26:28 EDT 
Fix is in HEAD (OrganizeImportsPerfTest rev. 1.6.) but needs to be backported to perf_34x.
Comment 10 Dani Megert CLA 2008-10-16 10:58:52 EDT 
Backported to perf_34x.