Bug 209506 - [spy] duplicate help context identifiers on editors
Summary: [spy] duplicate help context identifiers on editors
Status: CLOSED WONTFIX
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2007-11-12 10:39 EST by Chris Aniszczyk CLA
Modified: 2019-09-09 02:36 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2007-11-12 10:39:44 EST
If you select the Manifest Editor in PDE and run the spy, you get duplicate help context ids:

org.eclipse.pde.doc.user.manifest_source_page
org.eclipse.ui.text_editor_context
org.eclipse.pde.doc.user.manifest_source_page
org.eclipse.ui.text_editor_context
org.eclipse.pde.doc.user.manifest_source_page
org.eclipse.ui.text_editor_context
org.eclipse.pde.doc.user.manifest_plugin_dependencies
Comment 1 Chris Aniszczyk CLA 2007-11-12 10:44:23 EST
Remy :P
Comment 2 Chris Aniszczyk CLA 2007-11-12 10:44:43 EST
actually, Brian :P
Comment 3 Remy Suen CLA 2007-11-12 11:09:16 EST
I added some print statements and Widgets with different hashCode() return values are printing out the same help context ids. It sounds like the id association is being performed multiple times.
Comment 4 Kevin Doyle CLA 2007-12-04 20:10:54 EST
I noticed this in RSE's Remote Shell view as well and it was because we are adding the help multiple times.

For the Manifest Editor it's the same reason.  In ManifestEditor.addEditorPages() we are adding 3 source pages (PDESourcePage).  Inside PDESourcePage.createPartControl() we are adding the help for the manifest_source_page.  PDESourcePage extends TextEditor and inside TextEditor.initializeEditor() we are setting the help context id for the text editor.  Inside AbstractTextEditor.createPartControl() we use the help context id that was set and set the help for the editor.  This is why we have 3 of the manifest_source_page and text_editor_context help id's.
Comment 5 Eclipse Webmaster CLA 2019-09-06 15:37:00 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 6 Julian Honnen CLA 2019-09-09 02:36:05 EDT
Please remove the stalebug flag, if this issue is still relevant and can be reproduced on the latest release.