Community
Participate
Working Groups
Created attachment 82602 [details] misc fixes This is for improved i/o with the bot, HTMLified commands, and using the commands themselves as regexes instead of simply as comments in the properties file. See also comments / TODOs in attached patch.
Oops. Line 346 should also check for null: - while (input.indexOf(SUM_CLOSE_TAG) == -1) { + while (input != null && input.indexOf(SUM_CLOSE_TAG) == -1) {
Patches that are over 250 lines needs to have the IP process invoked. Of course, we'd rather not do that. Nick, can you create smaller patches that tackles specific issues or enhancements please? It'd make it easier for me to review anyway. As I review and commit them, you can add attach another one to the bug. Don't worry about externalizing every single string (including the ones that haven't been externalized), some of them I've forgotten about, some of them I'm leaving it on purpose because I want to remind myself to externalize them / make them into constants later.
Created attachment 82699 [details] 146 LOC patch to generate HTML from commands and externalize command regexs into properties patch part 1: `grep "+" ecf-kosmos-create-commands.html.patch | grep -v "@@" | wc -l` returns 146 lines of new and refactored code
Created attachment 82701 [details] 82 LOC patch for improved error handling, TODOs, and HTML output w/ line breaks and highlighting for {0} replacements patch part 2: `grep "+" ecf-kosmos-better-error-handling-and-html-output.patch | grep -v "@@" | wc -l` returns 82 lines of new and refactored code This patch was built assuming that part 1 was NOT applied, so it should be able to be applied on top of part 2. Hopefully.
Attachment 82699 [details] has been applied and KOS-MOS has been restarted as of this comment. Attachment 82701 [details] cannot be overlaid cleanly, as expected.
Created attachment 83293 [details] add colour to commands.html; better handling for NPEs; simplify cases when target == null Patch is 152 lines of new/changed code and 250 lines of removed/changed code. including some line reformatting/cleanup, which isn't new code, just me making the code prettier. I hope that passes the <250 line contraint. ;-)
Being the axesome Eclipse citizens we are, I have submitted CQ 1880 for Nick's attachment 83293 [details]. https://dev.eclipse.org/ipzilla/show_bug.cgi?id=1880
(In reply to comment #7) > https://dev.eclipse.org/ipzilla/show_bug.cgi?id=1880 CQ has been approved.
Leaving a Firefox tab open on this bug so I don't forget. Will try to address this this week before assignments starts rolling in. :)
Created attachment 86426 [details] Tweaked patch to correct some hiccups. Removed a print statement and also corrected the bug replies so that specified targets are not ignored.
Patch applied to CVS HEAD. KOS-MOS has been restarted. Thanks, Nick.
closing
