Bug 209206 - Add/Edit Filter Mapping dialog should give choice of the registered servlets
Summary: Add/Edit Filter Mapping dialog should give choice of the registered servlets
Status: CLOSED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.servlet (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M4   Edit
Assignee: Kaloyan Raev CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-11-08 10:52 EST by Kaloyan Raev CLA
Modified: 2008-05-12 09:13 EDT (History)
1 user (show)

See Also:

Attachments
Patch for add/edit mapping dialog (36.53 KB, patch)
2007-11-09 03:59 EST, Hristo Hristov CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kaloyan Raev CLA 2007-11-08 10:52:14 EST 
The new Add/Edit Filter Mapping dialog in the Filter wizard enables the user to add or edit both types of filter mappings: url patterns and servlets. 

At the moment the dialog gives choice the user to select among all classes in the classpath that implement the javax.servlet.Servlet interface. This is wrong according to the Servlet specification. The correct behavior is to give choice of all *registered* in web.xml servlets. 

The dialog should also be redesigned, so it does not have a selections of java classes, but of servlet objects.
Comment 1 Hristo Hristov CLA 2007-11-09 03:59:56 EST 
Created attachment 82521 [details]
Patch for add/edit mapping dialog

This patch fixs adding filter maping of servlet name how it have to be instead servlet's class names.
Comment 2 Kaloyan Raev CLA 2007-11-09 08:15:04 EST 
Patch is excellent, thanks. 
It will be committed next week when M4 is open for development.
Comment 3 Kaloyan Raev CLA 2007-11-26 05:02:19 EST 
dropped to HEAD.
Comment 4 Kaloyan Raev CLA 2007-12-27 12:30:48 EST 
Verified with the S-3.0M4-20071227065330 build.
Comment 5 David Williams CLA 2008-04-24 00:44:25 EDT 
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword.
Comment 6 Kaloyan Raev CLA 2008-05-12 09:13:34 EDT 
Closing