Bug 209150 - [dom] Recovered type binding for "java.lang.Object" information are not complete
Summary: [dom] Recovered type binding for "java.lang.Object" information are not complete
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.3.2   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-08 05:02 EST by Frederic Fusier CLA
Modified: 2008-11-02 01:24 EST (History)
6 users (show)

See Also:
philippe_mulet: pmc_approved+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2007-11-08 05:02:49 EST 
3.4M3 but at least since 3.3.

Follow-up for bug 186410 comment 15 (Markus):
The recovered 'Object' type binding is still a bit strange, since it has name
"Object" and a package binding with name "p" but a qualifiedName "Object".

Expected: either qualifiedName "p.Object", or better yet "java.lang.Object" and
a package binding for "java.lang" (since ITypeBinding.getSuperclass() suggests
to test for "java.lang.Object").
Comment 1 Frederic Fusier CLA 2007-11-08 05:03:57 EST 
bug 186410 comment 16 (Olivier):

In this specific case, we could indeed do better.
We retrieve a missing binary type binding that contains the right package
binding and the right fully qualified name.
So we should improve:
-getPackage() to return the package binding corresponding to the package
binding inside the missing binary type binding. This will involve updating the
doc for ITypeBinding#getPackage().
- getQualifiedName() to return a consistent name wrt the package name
- getName() same for the single name
Comment 2 Frederic Fusier CLA 2007-11-08 12:57:27 EST 
Patch for bug 186410 includes fix for this bug...
Comment 3 Frederic Fusier CLA 2007-11-08 13:47:24 EST 
Released for 3.4M4 in HEAD stream.
Comment 4 Frederic Fusier CLA 2007-11-13 10:08:54 EST 
Released for 3.3.2 in R3_3_maintenance stream.
Comment 5 Jerome Lanneluc CLA 2007-11-21 05:27:15 EST 
Fine-tuning fix for bug 186410. Philippe please approve for 3.3.2.
Comment 6 Philipe Mulet CLA 2007-11-22 06:50:07 EST 
I understand bug 186410 to be critical for 3.3.2, but this one sounds more like nice to have (almost cosmetical).
Why do we need it as well for 3.3.2 ? 
Is it trivial, and providing lots of good things ?
Comment 7 Frederic Fusier CLA 2007-11-22 07:20:35 EST 
(In reply to comment #6)
> I understand bug 186410 to be critical for 3.3.2, but this one sounds more like
> nice to have (almost cosmetical).
> Why do we need it as well for 3.3.2 ? 
> Is it trivial, and providing lots of good things ?
> 
In fact the fix for bug 186410 is a change in getSuperclass() method using getQualifiedName(). So, this method needs the fix for bug 209150 to work properly and return the name really qualified...
Comment 8 Philipe Mulet CLA 2007-11-23 09:18:18 EST 
+1 for 3.3.2
Comment 9 David Audel CLA 2007-12-12 05:13:12 EST 
Verified for 3.4M4 using build I20071210-1800.
Comment 10 Maxime Daniel CLA 2008-01-24 04:08:57 EST 
The test cases mistakenly bug 209510 instead of this bug 209510 (in both maintenance and HEAD), you may want to fix this. But the fix is in though.

Verified for 3.3.2 using build M20080123-0800 and tests from version v_791_R33x.
Comment 11 Frederic Fusier CLA 2008-01-24 05:09:20 EST 
(In reply to comment #10)
> The test cases mistakenly bug 209510 instead of this bug 209510 (in both
> maintenance and HEAD), you may want to fix this. But the fix is in though.
> 
It seems that dyslexia comes naturally while referring to this bug ;-)
Thanks for having pointed this, I've fixed it in both stream but of course, we won't ask for a rebuild in maintenance stream for this change...