Community
Participate
Working Groups
Need to enable "Detail Pane" for the module view
Hi Pawel I was looking into the "detailsPane" view for Modules. Some observations and questions details pane in CDT for modules is created, initialized and filled inside ModulesView. Since we are using this view, Don't you think we need to use CDT details pane view for view and content needs to be filled by DSF ? May be doComputeDetail() in ModulesView.java need to be modified so that it can delegate the call to fill the information to the context that invoked it. This is what I could understand but may be I have completely missed a point here. Coz you mentioned creating a new extension point to achieve the same. I also looked into the extension point part. I am unclear about how it can be used. DSF has used an extension point to create a factory for detail pane views. Since its a factory I think you meant using this factory to create a different pane for modules ? If yes, then how can we hook this to the CDT modules view ? Any lead is appreciated. I know you are quite busy so please take your time to answer. I am not in a hurry. Thanx Veenu
If the CDT modules view does not use the extension point mechanism for detail pane, which the platform views use, then it should be fixed. I will take a look at this when I get some time.
Created attachment 84961 [details] Details pane view for Modules Details pane view for Modules
Hi Veenu, I'm reassigning this bug to you since you're working on it. And you're almost already done with it :-) Your check-in broke the build because there were a couple of details missing: 1) dependency on org.eclipse.cdt.debug.ui - I added this to plugin.xml already 2) ModulesLayoutNode.updateLabelInSessionThread() references IDsfDebugUIConstants - I'm guessing you forgot to check in IDsfDebugUIConstants, but it was in the patch, so I committed it to CVS. A couple more comments: a) ModulesDetailPane references ModulesMessages class, which is an internal class in cdt.debug.ui. We should have our own version of the externalized Strings. But please use the new-style for externalizing strings rather than the one in CDT. See org.eclipse.dd.dsf.debug.ui.viewmodel.expression for an example. b) I noticed you copied the images from cdt.ui. Since CDebugUIImages is in an internal package this makes perfect sense. However, I'm going to request that CDT make these and other images available through a public API. So in the future I hope we'll be able to just reference the images from CDT directly, rather than duplicating them.
