Bug 208435 - Rename when pasting multiple files
Summary: Rename when pasting multiple files
Status: CLOSED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.0 M4   Edit
Assignee: Rupen Mardirossian CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 210682
  Show dependency tree
 
Reported: 2007-11-01 11:08 EDT by Rupen Mardirossian CLA
Modified: 2011-05-25 07:23 EDT (History)
2 users (show)

See Also:

Attachments
Patch to disable the user to rename to the same name when multiple collisions occur (12.38 KB, patch)
2007-11-09 15:47 EST, Rupen Mardirossian CLA 		no flags Details | Diff
Patch to disable the user to rename to the same name when multiple collisions occur (12.43 KB, patch)
2007-11-09 15:56 EST, Rupen Mardirossian CLA 		no flags Details | Diff
Patch to disable the user to rename to the same name when multiple collisions occur (12.55 KB, patch)
2007-11-12 14:52 EST, Rupen Mardirossian CLA 		mober.at+eclipse: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rupen Mardirossian CLA 2007-11-01 11:08:31 EDT 
** When I copy and paste some files to the same folder, I rename those file to the same name, RSE dose not compliant
anything. And the pasted files override each other

Step to reproduce:
1. Switch to RSE perspective
2. In a folder, create some files, e.g. "file1", "file2", "file3"..
3. Copy all 3 files and paste to the same folder
4. The "Duplicate Name Collision" dialog pops up, select the "Rename" radio 
button with name "file4" for all 3 files.
5. RSE does not compliant the file4 as an existing name and just override it with the new files. 
RSE should warn that file4 exists when pasting file2 and file3 to file4

-----------Enter bugs above this line-----------
installation : eclipse-SDK-3.3.1 
RSE install  : dev driver
java.runtime : Sun 1.6.0_03-b05
os.name:     : Windows XP 5.1, Service Pack 2
------------------------------------------------
Comment 1 David McKnight CLA 2007-11-08 15:19:46 EST 
Rupen, as discussed, I'll assign this for you to look at.
Comment 2 Rupen Mardirossian CLA 2007-11-09 15:47:50 EST 
Created attachment 82570 [details]
Patch to disable the user to rename to the same name when multiple collisions occur

This patch is to disable the user from renaming to the same name when multiple collisions occur.  Basically passing a list of previously selected names to the dialog, having the dialog check on the validate whether the users entered string exists within the list.
Comment 3 Rupen Mardirossian CLA 2007-11-09 15:56:33 EST 
Created attachment 82571 [details]
 Patch to disable the user to rename to the same name when multiple collisions occur

Sorry, noticed in the Diff screen that i missed a line of code.
Comment 4 Rupen Mardirossian CLA 2007-11-12 14:52:57 EST 
Created attachment 82698 [details]
Patch to disable the user to rename to the same name when multiple collisions occur

Reposting due to synchronizing issues as per Dave M.
Comment 5 David McKnight CLA 2007-11-12 15:16:03 EST 
The patch looks good.  I've committed the changes to cvs.  Thanks!
Comment 6 Rupen Mardirossian CLA 2007-11-16 09:42:38 EST 
The problem for this defect has been verified in that the same name cannot be used more than once for renaming.  Although, I have discovered an issue which i will open as another defect.  Only in local, 

1) When there is a folder collision during copy
2) Select to rename
3) Select a name of a folder that exists in the parent
4) No error is given and folder is overwritten