Bug 208263 - [ast rewrite] performance problems with lots of changes
Summary: [ast rewrite] performance problems with lots of changes
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3.2   Edit
Assignee: Martin Aeschlimann CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2007-10-31 12:03 EDT by Martin Aeschlimann CLA
Modified: 2007-12-11 09:49 EST (History)
4 users (show)

See Also:
philippe_mulet: pmc_approved+

Attachments
Patch replacing the linear list with a map (patch for 3.0.2) (7.17 KB, patch)
2007-10-31 12:51 EDT, Martin Aeschlimann CLA 		no flags Details | Diff
final patch for 3.0.2 (7.57 KB, patch)
2007-11-02 07:29 EDT, Martin Aeschlimann CLA 		no flags Details | Diff
patch for 3.3.2 and 3.4 (7.82 KB, patch)
2007-11-02 07:30 EDT, Martin Aeschlimann CLA 		no flags Details | Diff
patch for 3.3.2 and 3.4 (7.82 KB, patch)
2007-11-02 07:31 EDT, Martin Aeschlimann CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2007-10-31 12:03:28 EDT 
20071031

As the node change events are managed in a linear list, the AST rewriter gets in trouble with huge number of events.
Comment 1 Martin Aeschlimann CLA 2007-10-31 12:51:14 EDT 
Created attachment 81739 [details]
Patch replacing the linear list with a map (patch for 3.0.2)
Comment 2 Martin Aeschlimann CLA 2007-11-02 07:29:59 EDT 
Created attachment 81942 [details]
final patch for 3.0.2
Comment 3 Martin Aeschlimann CLA 2007-11-02 07:30:24 EDT 
Created attachment 81944 [details]
patch for 3.3.2 and 3.4
Comment 4 Martin Aeschlimann CLA 2007-11-02 07:31:09 EDT 
Created attachment 81945 [details]
patch for 3.3.2 and 3.4
Comment 5 Martin Aeschlimann CLA 2007-11-02 07:40:44 EDT 
patches released for 3.3.2 and 3.4 > 20071102
Comment 6 Jerome Lanneluc CLA 2007-11-02 08:53:41 EDT 
(In reply to comment #2)
> Created an attachment (id=81942) [details]
> final patch for 3.0.2
Released in R3_0_maintenance branch.
Comment 7 Jerome Lanneluc CLA 2007-11-02 10:05:18 EDT 
Released in R3_1_maintenance branch
Comment 8 Jerome Lanneluc CLA 2007-11-02 11:14:32 EDT 
Released in R3_2_maintenance branch
Comment 9 Jerome Lanneluc CLA 2007-11-02 12:27:21 EDT 
(In reply to comment #5)
> patches released for 3.3.2 and 3.4 > 20071102
Released for 3.4M4
Comment 10 Jerome Lanneluc CLA 2007-11-21 05:19:50 EST 
We saw that this fix dramatically improved the build time of a builder (from 5 hours to 51 minutes).  This fix needs to be included in 3.3.2. Philippe please approve.
Comment 11 Philipe Mulet CLA 2007-11-21 12:33:51 EST 
+1 for 3.3.2
Comment 12 Eric Jodet CLA 2007-12-11 09:49:06 EST 
Verified in the code for 3.4 M4 using build I20071210-1800.