Bug 208234 - Specify that CodeFormatter is not intended to be subclassed
Summary: Specify that CodeFormatter is not intended to be subclassed
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Eric Jodet CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-31 10:48 EDT by Jerome Lanneluc CLA
Modified: 2007-12-11 07:43 EST (History)
2 users (show)

See Also:

Attachments
[patch] - proposed correction (803 bytes, patch)
2007-11-07 07:51 EST, Eric Jodet CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2007-10-31 10:48:31 EDT 
I20071031-0010

org.eclipse.jdt.core.formatter.CodeFormatter doesn't specify whether can subclass it or not. However, the intent was never to allow clients to subclass it. Clients can only obtain a new CodeFormatter using ToolFactory#createCodeFormatter(...).

We should add the following to the Javadoc:

 * <p>
 * This class is not intended to be instantiated or subclassed by clients.
 * </p>
Comment 1 Jerome Lanneluc CLA 2007-10-31 10:49:18 EDT 
Eric, please make the change for 3.4M4.
Comment 2 Eric Jodet CLA 2007-11-07 07:51:28 EST 
Created attachment 82317 [details]
[patch] - proposed correction

(In reply to comment #1) - contains the modified javadoc
Comment 3 Eric Jodet CLA 2007-11-07 07:54:11 EST 
Patch released for 3.4M4 in HEAD.
Comment 4 Eric Jodet CLA 2007-11-07 07:56:02 EST 
Fixed in HEAD
Comment 5 David Audel CLA 2007-12-11 07:43:48 EST 
Verified for 3.4M4 using build I20071210-1800.