Bug 208097 - [spy] some context ids are missed
Summary: [spy] some context ids are missed
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2007-10-30 15:17 EDT by Chris Aniszczyk CLA
Modified: 2007-10-31 18:33 EDT (History)
2 users (show)

See Also:

Attachments
patch to fix this problem (5.66 KB, patch)
2007-10-31 15:40 EDT, Brian Bauman CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2007-10-30 15:17:42 EDT 
The spy currently misses certain context ids... like the package explorer. The algorithm needs to be improved to match what Help does...

should look at 

org.eclipse.help.ui.internal.views.ContextHelpPart.findHelpContext(Control)
Comment 1 Brian Bauman CLA 2007-10-31 15:40:00 EDT 
Created attachment 81766 [details]
patch to fix this problem

The package explorer implements an adapter for IContextProvider.  This is why the current algorithm was not successful in finding the context id.

Since I had to add org.eclipse.help to the manifest as an optional dependency, I also updated the PDERuntimePlugin.HAS_IDE_BUNDLES.
Comment 2 Chris Aniszczyk CLA 2007-10-31 17:57:40 EDT 
You're so smart Brian.
Comment 3 Chris Aniszczyk CLA 2007-10-31 18:33:08 EDT 
nice, thanks Brian, just in time.