Bug 207648 - Speed up weaving option: favor occasional runtime tests
Summary: Speed up weaving option: favor occasional runtime tests
Status: NEW
Alias: None
Product: AspectJ
Classification: Tools
Component: LTWeaving (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-26 19:57 EDT by Ron Bodkin CLA
Modified: 2013-06-24 11:05 EDT (History)
1 user (show)

See Also:


Attachments
Implementation Patch (4.21 KB, patch)
2007-10-26 19:57 EDT, Ron Bodkin CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ron Bodkin CLA 2007-10-26 19:57:27 EDT
Created attachment 81313 [details]
Implementation Patch

The current LTW strategy to avoid instanceof tests adds about 10% overhead to the weaving process from my profiling. This patch uses some fast matching (checking hashcodes before string equals) and also provides a Xset option to favor faster loading rather than faster runtime performance (i.e., sometimes it will produce an instanceof test where full analysis would have realized one wasn't necessary). My tests show that this is a very improbable event, so for my needs the reduced overhead at load-time was far more preferable.
Comment 1 Andrew Clement CLA 2007-10-29 04:50:56 EDT
take a look for 1.5.4
Comment 2 Andrew Clement CLA 2013-06-24 11:05:03 EDT
unsetting the target field which is currently set for something already released