Bug 207497 - Instance Breakpoint Dialog from Variables View is confusing
Summary: Instance Breakpoint Dialog from Variables View is confusing
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M3   Edit
Assignee: JDT-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2007-10-25 14:46 EDT by Samantha Chan CLA
Modified: 2007-10-26 14:53 EDT (History)
2 users (show)

See Also:

Attachments
patch (4.08 KB, text/plain)
2007-10-26 14:21 EDT, Samantha Chan CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samantha Chan CLA 2007-10-25 14:46:51 EDT 
My workspace has some breakpoints.  I started a debug session, and from the variables view, select a variable and open the "Instance Breakpoint..." dialog.  Because none of the breakpoints apply to my selected variable, the dialog is comes up empty.  In the dialog, both the OK and CANCEL buttons are enabled and clicking on them has no effect to my breakpoints.  There is no feedback on where some instance breakpoint filter is applied or not. 

If no breakpoint can be applied to the selected variable, the dialog should not be brought up.  Or, the dialog should indicate that breakpoint filtering is not possible.
Comment 1 Curtis Windatt CLA 2007-10-25 14:52:43 EDT 
Tomorrow is bug day... :)
Comment 2 Samantha Chan CLA 2007-10-26 14:21:56 EDT 
Created attachment 81285 [details]
patch 

Here's my bug/cookie day contribution.  :)

The patch simply pops up a dialog to notify that instance breakpoint filter is not possible.

I looked at hiding the action all together using JavaVarActionFilter.  But that action filter seems to be only for checking on the type of the selected object.  In addition, seems expensive to have to check all the breakpoints before bringing up the context menu.
Comment 3 Darin Wright CLA 2007-10-26 14:52:51 EDT 
Thanks. Applied patch (small modification to NLS message).
Comment 4 Darin Wright CLA 2007-10-26 14:53:09 EDT 
Verified.