Community
Participate
Working Groups
Thanks Jacek - really nice addition ( bug 202583 ). But another little nice to have would be something to show which is the current session. Maybe bold it or something like this.
Can you try to squeeze this one in for M3 Jacek to top off the log view additions?
tagging bugday
Created attachment 81013 [details] patch sorry, I had no time to see how to bold out some text in a table using viewer. So for start I made that it shows a text like "Current Session" for current session. Notes to patch: - until now LogViewLabelProvider was kind of state-less - could have multiple consumers. Now it's stateful, since it has to query the consumer which log session is most recent. (Different consumers could have different items sorted in different ways, so it would be hard to guess which one is first actually) - i refactored out this neat call: !fInputFile.equals(Platform.getLogFileLocation().toFile()) to LogView.isImportMode() as a couple of places use it. As a result, EventDetailsDialog has to create his own instance of laber provider, instead of using the one from LogView. How I tested: - with imported external file - with current workbench file - changing order of table sorting
This doesn't work properly I think. If you launch Eclipse with existing log entries... you should see "Session" for all of them. Once there's a new log entry, I'm assuming there will be a "Current Session" to reflect the new entries. There shouldn't be a "Current Session" on sessions that aren't part of say the current running instance :)
ah I see, I'll try to update this later this week.
Thanks Jacek!
(In reply to comment #4) Chris, after reading this once again, I think the current patch is ok. With it, new session starts when Eclipse is launched. Any errors/warnings during launch are added to current session, which later shows up in ErrorLog once it's established. If log is imported, no session is marked as current session. I am not sure how you tested this patch, but maybe the main issue is bug 207410 - the entries were added to wrong session. So please review this patch after bug 207410 is finished.
Chris, if you don't have time to review the patch again let me know and I will take a look at it. Thanks Jacek for your hard work!
(In reply to comment #8) > Chris, if you don't have time to review the patch again let me know and I will > take a look at it. Thanks Jacek for your hard work! Brian, thanks for your attention :) Could we wait with this until bug 207344 is finished? I think it's bigger and will impact implementation of this one...
> Brian, thanks for your attention :) Could we wait with this until bug 207344 is > finished? I think it's bigger and will impact implementation of this one... Sure, I am in no rush. Just let us know when you are ready for us to review the patches :)
Hey Jacek, how about this one? How about instead of "Current Session" maybe bolding the font of "Session"?
Created attachment 84373 [details] bolding current session as you wish :)
Created attachment 84374 [details] mylyn/context/zip
Awesome Jacek, you're my hero of the 3.4M4 release! Thanks! I like how this looks :)
verified on I20071211-0010
