Bug 207061 - [logview] setting filter to 0 log messages should not display session roots
Summary: [logview] setting filter to 0 log messages should not display session roots
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Jacek Pospychala CLA
QA Contact: Brian Bauman CLA
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-10-22 11:17 EDT by Chris Aniszczyk CLA
Modified: 2007-10-30 15:34 EDT (History)
2 users (show)

See Also:

Attachments
patch (1.22 KB, patch)
2007-10-23 18:56 EDT, Jacek Pospychala CLA 		no flags Details | Diff
mylyn/context/zip (765 bytes, application/octet-stream)
2007-10-24 10:22 EDT, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2007-10-22 11:17:43 EDT 
See the attached picture of what happens when you set the filter to 0 items.
Comment 1 Chris Aniszczyk CLA 2007-10-22 11:18:01 EDT 
punting to Jacek.
Comment 2 Jacek Pospychala CLA 2007-10-22 17:25:02 EDT 
ok, so lets assume this preference is the limit of all events in all sessions and sessions don't count as events.
Comment 3 Jacek Pospychala CLA 2007-10-23 18:56:59 EDT 
Created attachment 81011 [details]
patch

if events limit is set to zero, don't parse the log at all.

I tested that:
- with this fix, after importing a log and setting different values (0,1,2) to events limit works fine.
- current Eclipse log (so not the imported one), works anyway. I've ensured that Eclipse will throw some errors by including plug-ins without their dependencies. Then, when I was setting events limit to 0 session didn't showed up. Setting to higher values worked correctly.

Let me know, if I missed any other cases.

I have also added I comment to one method that distracts me every time I look at it...
Comment 4 Chris Aniszczyk CLA 2007-10-24 10:22:37 EDT 
Looks good! Thanks Jacek :)
Comment 5 Chris Aniszczyk CLA 2007-10-24 10:22:42 EDT 
Created attachment 81064 [details]
mylyn/context/zip