Bug 206884 - [terminal][api] Serial Terminal owner identifier should not be an internal package name
Summary: [terminal][api] Serial Terminal owner identifier should not be an internal pa...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: Terminal (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.0 M6   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 221184
  Show dependency tree
 
Reported: 2007-10-19 09:20 EDT by Martin Oberhuber CLA
Modified: 2008-04-09 17:59 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-10-19 09:20:54 EDT 
The Serial Terminal opens a port with an ownership identifier of

SerialConnectWorker#run() {
  final String strID = getClass().getPackage().getName();
}

But this identifier is visible outside, so it is part of API. It would be better to have the plugin name as identifier, or even a translated user-readable String like "TM Terminal View".

Personally, I think it would be best to use the plugin name:
org.eclipse.tm.terminal.serial
Comment 1 Martin Oberhuber CLA 2008-04-09 17:59:53 EDT 
Fix committed:
[206884] Update Terminal Ownership ID to "org.eclipse.tm.terminal.serial"