Bug 206352 - Resilient class file reader
Summary: Resilient class file reader
Status: VERIFIED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M5   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-15 12:39 EDT by Jerome Lanneluc CLA
Modified: 2010-01-25 01:11 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2007-10-15 12:39:43 EDT 
I20071010-1200

Bug 195823 shows that we are sensitive to the class file format. As we are resilient for .java files that have syntax errors, we should be resilient to .class files that have class file format problems.

One way to implement that would be to keep the existing class file reader, but catch ClassFormatException in its API methods and call a resilient class file reader. This way we would keep the performance of the existing class file reader and be more resilient.
Comment 1 Olivier Thomann CLA 2009-06-26 11:21:33 EDT 
I think handling class format exception in the binary indexer is good enough. Having a resilient class file reader means we would somehow "trust" part of the class file before it is corrupted.
If a class file is corrupted, we should not rely on any information it provides.
I would close as WONTFIX.
This is fine for you, Jérôme?
Comment 2 Olivier Thomann CLA 2009-12-09 10:48:14 EST 
Closing as WONTFIX.
Comment 3 Srikanth Sankaran CLA 2010-01-25 01:11:44 EST 
Verified for 3.6M5