Bug 20608 - "Invalid thread access" when closing a project.
Summary: "Invalid thread access" when closing a project.
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC other
: P2 critical (vote)
Target Milestone: 2.0 F4   Edit
Assignee: Dejan Glozic CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-06-18 18:28 EDT by Michael R. Head CLA
Modified: 2002-06-20 14:00 EDT (History)
3 users (show)

See Also:


Attachments
relevant section of my workspace's .metadata/.log file (73.40 KB, text/plain)
2002-06-18 18:30 EDT, Michael R. Head CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael R. Head CLA 2002-06-18 18:28:28 EDT
This is going to be a poor bug report, because the bug is one of these random
bogon bugs and not necessarily reproducable... but I thought I should log into
the bugzilla, anyway.

After doing some various UI tasks (such as configuring my launch
configurations), I am getting an "Invalid thread access" message when I close
the project I am working on (it happens to be an eclipse plugin).

I will attack my log from the relevant run of eclipse.

mike
Comment 1 Michael R. Head CLA 2002-06-18 18:30:26 EDT
Created attachment 1491 [details]
relevant section of my workspace's .metadata/.log file
Comment 2 Michael R. Head CLA 2002-06-18 20:27:21 EDT
I suppose I should provide some more details of the system I'm running on:

Debian sid/unstable (I can provide library version details if necessary)

Sun's JDK1.4.0
java -version:
java version "1.4.0"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.4.0-b92)
Java HotSpot(TM) Client VM (build 1.4.0-b92, mixed mode)

Ant version 1.5beta1
/usr/bin/ant -version:
Apache Ant version 1.5Beta1 compiled on May 26 2002

mike
Comment 3 Michael R. Head CLA 2002-06-18 20:28:59 EDT
d'oh. silly bugzilla. That was meant for a different bug report... (the JVM I
used when this stack trace was generated was Blackdown's 1.3.1, so it's not even
useful information)

mike
Comment 4 Nick Edgar CLA 2002-06-18 23:49:47 EDT
This is actually a good bug report, thanks.
However, please indicate which build you were running in PRs.
Among other things, this helps in figuring out which code is referred to by 
line numbers in stack dumps.

The thread exception is due to PDE's log view not doing a syncExec or 
asyncExec when talking to the viewer.  In these cases, log entries are being 
added by threads other than the UI thread, and the log view is notified in the 
same thread.

Marking as critical because this bug makes the log view unusable.

There are secondary errors here from VCM and JDT Debug.  

Also, it doesn't look like the log entries being added when the thread 
exception occurred actually ended up in the log.
For the last stack, line 120 of SyncFileChangeListener is:

    } catch(CVSException e) {
	CVSProviderPlugin.log(e.getStatus());    // line 120
    }

and I don't see any CVSException or its subclasses in the log.
Core should check that it writes to the log file -before- notifying listeners.



Comment 5 Darin Wright CLA 2002-06-18 23:58:11 EDT
The "non-existant" project errors logged by the debugger are the result of 
agressive error logging. The referenced project may no longer exist in the 
workspace (or may be closed). The launch config dialog still operates.
Comment 6 Michael R. Head CLA 2002-06-19 01:13:59 EDT
d'oh. Yeah, this occured on F3.
Comment 7 Dejan Glozic CLA 2002-06-19 09:27:21 EDT
Consider fixing for F4 - react to log notification using asyncExec
Comment 8 Kevin McGuire CLA 2002-06-19 11:09:15 EDT
The cvs bug in the log has been fixed by 20421 since F3.
Comment 9 DJ Houghton CLA 2002-06-19 15:14:20 EDT
Created new bug 20680 to add improved support for logging messages and 
exceptions. The problem (w.r.t. log file writing) was that the PDE log file 
listener threw an Error and therefore no other listeners (inluding the 
platform log listener) had a chance to log the original CVS exception.
Comment 10 Dejan Glozic CLA 2002-06-20 14:00:52 EDT
Fixed