Bug 205451 - Plugin Manifest editor's "Add" button on extension page places dialog in wrong place
Summary: Plugin Manifest editor's "Add" button on extension page places dialog in wron...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2007-10-04 11:43 EDT by Nathan Tolbert CLA
Modified: 2007-10-24 11:47 EDT (History)
3 users (show)

See Also:

Attachments
Fix (865 bytes, patch)
2007-10-09 16:48 EDT, Curtis Windatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Tolbert CLA 2007-10-04 11:43:47 EDT 
Build ID: I20070621-1340

Steps To Reproduce:

1.  (Optionally, to make this easier to observe) run eclipse in a 2-monitor setup, with Eclipse in the right-most monitor.
2.  Open the manifest editor for a plugin
3.  Go to the Extensions tab
4.  Click "Add" to add a new extension

The dialog that appears will not appear in a positive relative to your Eclipse window, as all the rest of the dialogs do.  Instead, it appears relative to your display.

This is mostly easily replicated if you use multiple monitors, and place the eclipse window in the right-most monitor.  When you click add, the dialog will appear in the left-most monitor.  



More information:
Comment 1 Brian Bauman CLA 2007-10-08 13:29:31 EDT 
Do you see this problem with other pop-up menus or just PDE's?
Comment 2 Nathan Tolbert CLA 2007-10-09 11:30:32 EDT 
The only popup dialog that I have seen it with is the "Add" button of the Extensions tab of the PDE editor.  

I have tested all the other buttons in the PDE editor that create popups, (such as the "Add" button on the Extension Points tab) and none of the rest have this behavior.  

I just downloaded build I20071002-1342, and the problems exists in this version as well.  

I can upload a small video of the bug if it would be helpful.
Comment 3 Nathan Tolbert CLA 2007-10-09 11:31:19 EDT 
To clarify, the problem doesn't occur in any other popup dialogs throughout eclipse that I have used, either.
Comment 4 Curtis Windatt CLA 2007-10-09 14:48:36 EDT 
I can reproduce using I20071002-1342, the wizard opens up on the left side of my screen while all others open up in the middle.  The add extension wizard is the only one that does this, even though the wizard to add a new extension point entry is opened in the same fashion.  I didn't see anything in the PDE code that would cause the difference.
Comment 5 Brian Bauman CLA 2007-10-09 16:39:45 EDT 
I heard through the grapevine that Curtis has a fix ;-)
Comment 6 Curtis Windatt CLA 2007-10-09 16:48:00 EDT 
Created attachment 79999 [details]
Fix

The wizard dialog is given a set size of 500 by 500.  PointSelectionPage, the wizard page that opens up, gets the shell and sets it to 500 by 500.  By removing this additional attempt to adjust the size, the dialog opens in the center of the screen.
Comment 7 Brian Bauman CLA 2007-10-09 16:55:18 EDT 
Looks great.  Nice job Curtis.  Will be available in 3.4M3
Comment 8 Brian Bauman CLA 2007-10-24 11:47:05 EDT 
verified on I20071023-0800