Community
Participate
Working Groups
Created attachment 79690 [details] Patch to add three XML Attribute templates. Currently the XML editors for WST contribute comment, xml declaration and xsl declaration templates. The supplied patch, adds three additional xml attribute templates as well. 1. XML Schema Instance namespace. Creates the appropriate xmlns entry for the XML Schema Instance namespace. 2. XML Schema Location. Creates the attribute entry to define the xml schemalocation. Useful for when an XML file may not have this included or a program didn't generate it. 3. No Schema Location. Creates the attribute entry for the schema location. User still needs to fill in the appropriate location.
I took a look at the attached patch and it looks like there are actually 4 templates, not 3. Was an extra one accidentaly added in the patch? Also, the templates for schema location & no schema location are the same. I'm a little hesitant about adding these templates because I wonder if some of these are actually better as regular content assist proposals. I know I've see xsi:type proposed before. Maybe xsi:schemaLocation & xsi:noNamespaceSchemaLocation should also be proposed.
(In reply to comment #1) > I took a look at the attached patch and it looks like there are actually 4 > templates, not 3. Was an extra one accidentaly added in the patch? > > Also, the templates for schema location & no schema location are the same. > > I'm a little hesitant about adding these templates because I wonder if some of > these are actually better as regular content assist proposals. I know I've see > xsi:type proposed before. Maybe xsi:schemaLocation & > xsi:noNamespaceSchemaLocation should also be proposed. > The last one is to add a default namespace. I agree that these should all really be included as default content assist, but currently it isn't done their. So either way is fine with me.
mass reassignment of my bugs to xml-inbox
Added, thanks, Dave!
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword.
Reopening. Valentin discovered that the schema location and no schema location templates are the same.
Dave, can you create a patch with a fix, whether that means removing or changing the templates?
(In reply to comment #6) > Reopening. Valentin discovered that the schema location and no schema location templates are the same. Well, I saw it just today, but reading the other comments let's give credit to Amy. In comment #1 she says the same thing. Must've been missed initially.
I'll look at getting a patch tomorrow.
Haven't forgotten about this... will try and address over the holidays.
Created attachment 118830 [details] Corrects No Namespace Schema Location template This patch corrects the No Namespace Schema Location template so that it's pattern is correct.
Patch uploaded...Valentin or Nitind do you want to review it and apply it?
Amy, as per our chat please take care of this fix. The better approach would be to close this bug and open new bugs for 3.0.4 and 3.1. Dave can attach the patch to the one for 3.0.4. That way the IP log and timeline for the fixes (target milestone) will be correct.
I'm resolving this bug back up as fixed because the fix was put into wtp 3.0 m6. I've opened bug 257250 & bug 257254 to track the issue reported in comment #6. Dave, could you please go ahead and attach your patch to those 2 bugs (I want to make sure I get the contribution credits correct) And I'll go ahead and release the fix for wtp 3.0.4 & wtp 3.1 m4. Thanks.
