Bug 205198 - Flag when there are missing bundle or package version ranges
Summary: Flag when there are missing bundle or package version ranges
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, noteworthy
Depends on:
Blocks:
 
Reported: 2007-10-02 11:16 EDT by Chris Aniszczyk CLA
Modified: 2008-09-05 10:36 EDT (History)
4 users (show)

See Also:

Attachments
org.eclipse.pde.patch (20.13 KB, patch)
2008-09-04 19:10 EDT, Chris Aniszczyk CLA 		no flags Details | Diff
mylyn/context/zip (47.46 KB, application/octet-stream)
2008-09-04 19:10 EDT, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2007-10-02 11:16:36 EDT 
In the effort to meet one of our themes for the 3.4 release, "Keep Tom Happy," we need to investigate adding a marker to optionally flag people who forget version ranges on Import-Package/Export-Package and Require-Bundle. It's a good OSGi practice to always include this information.

This is a good bugday exercise too.
Comment 1 Thomas Watson CLA 2007-10-02 11:40:18 EDT 
This should also be related to API tooling.  It would be nice if the API tooling could introspect the client (importer/requirer) code to determine the lowest possible version range of the package/bundle which can be imported/required.
Comment 2 Chris Aniszczyk CLA 2007-10-02 11:49:09 EDT 
Darin, think about this in terms of API tooling too. Tom is trying to get fancy on us ;)
Comment 3 Wassim Melhem CLA 2007-10-03 12:01:02 EDT 
Chris, if you want to add this flag and turn it on by default, then all PDE templates would have to start generate version ranges.
Comment 4 Chris Aniszczyk CLA 2007-10-03 12:05:13 EDT 
It won't be on by default, it will be an optional preference. Only sadistic OSGi-only developers would do such a thing :)
Comment 5 Wassim Melhem CLA 2007-10-03 12:23:48 EDT 
ok, but that compiler preference tab is getting pretty long.

we need to split at some point.
Comment 6 Chris Aniszczyk CLA 2007-10-03 12:28:17 EDT 
agreed, it's a PITA :(
Comment 7 Brian Bauman CLA 2007-10-03 12:45:21 EDT 
We could use collapsible sections like JDT does to help with the usability
Comment 8 Chris Aniszczyk CLA 2008-01-15 14:51:06 EST 
Let's target this for M5 and make this IGNORE by default
Comment 9 Chris Aniszczyk CLA 2008-01-15 15:09:59 EST 
I'll just do this later
Comment 10 Chris Aniszczyk CLA 2008-01-30 16:20:25 EST 
I envision there being two flags here:

1) consumers (ie., Import-Package, Require-Bundle)
2) producers (ie., Export-Package)

We should only flag the consumer when the producer provides a version to import.

I'll see if I can cook something up in the PDE kitchen for M5.
Comment 11 Brian Bauman CLA 2008-01-30 17:10:31 EST 
For right now, I think this will have to be set to ignore by default so that way we don't scare everyone once they download the latest build :)
Comment 12 Chris Aniszczyk CLA 2008-03-23 16:52:23 EDT 
Ok, with p2 going in for M6... I will do this in M7... too much going on right now for M6.
Comment 13 Chris Aniszczyk CLA 2008-04-28 17:18:17 EDT 
It makes me sad that this won't make it in 3.4.

We shall wait for 3.5
Comment 14 Chris Aniszczyk CLA 2008-09-04 19:10:16 EDT 
Created attachment 111742 [details]
org.eclipse.pde.patch

Adds support for validating import package versions, exported package versions and require bundle versions.
Comment 15 Chris Aniszczyk CLA 2008-09-04 19:10:22 EDT 
Created attachment 111743 [details]
mylyn/context/zip
Comment 16 Chris Aniszczyk CLA 2008-09-05 10:36:03 EDT 
FIXED in HEAD.

> 20080905

I'm going to open other bugs for quickfixes.