Bug 203894 - Allow connections styles to change after connections have been created
Summary: Allow connections styles to change after connections have been created
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy Zest (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-18 17:22 EDT by Ian Bull CLA
Modified: 2015-01-22 02:44 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Bull CLA 2007-09-18 17:22:58 EDT 
Zest connections styles should be changeable after the connections have been created.  Opening to investigate.
Comment 1 Ugo Sangiorgi CLA 2007-10-18 18:44:30 EDT 
Actually, there is an explicit condition on AbstractStructuredGraphViewer, if there is an input, a error is thrown. 
If i just comment the line, nothing else is affected, the graph viewer works perfectly fine and the connection style is really changed, it just works.

public void setConnectionStyle(int connectionStyle) {
		if (getInput() != null) {
		 //ZestException.throwError(ZestException.ERROR_CANNOT_SET_STYLE, "", null);
		}
		if (!ZestStyles.validateConnectionStyle(connectionStyle)) {
			ZestException.throwError(ZestException.ERROR_INVALID_STYLE, "", null);
		}
		this.connectionStyle = connectionStyle;
	}

Why exactly one cannot set the style after the graph is already set?
Comment 2 Alexander Nyßen CLA 2015-01-22 02:44:50 EST 
Re-assigning back to inbox, as Ian is no longer active committer.