Bug 203861 - BIRT report view doesn't allow multiple plots of selected properties.
Summary: BIRT report view doesn't allow multiple plots of selected properties.
Status: CLOSED FIXED
Alias: None
Product: STEM
Classification: Technology
Component: Internal (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: James Kaufman CLA
QA Contact: Daniel Ford CLA
URL:
Whiteboard:
Keywords: ui
Depends on: 203857
Blocks: 207453
  Show dependency tree
 
Reported: 2007-09-18 14:31 EDT by Daniel Ford CLA
Modified: 2009-10-29 14:14 EDT (History)
1 user (show)

See Also:


Attachments
Shows all properteis in the time series display (17.23 KB, patch)
2007-10-09 17:22 EDT, James Kaufman CLA
webdaford: iplog+
Details | Diff
Stand Alone Time series Patch (19.82 KB, patch)
2007-10-12 13:38 EDT, James Kaufman CLA
webdaford: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Ford CLA 2007-09-18 14:31:35 EDT
The BIRT report view only plots the relative value of a single property.  It would be better to allow it to plot the values of multiple properties.
Comment 1 James Kaufman CLA 2007-10-09 17:22:59 EDT
Created attachment 80003 [details]
Shows all properteis in the time series display

Shows all properteis in the time series display
Comment 2 Daniel Ford CLA 2007-10-09 22:10:32 EDT
I applied the patch and got a compilation error in ChartCanvas.java line 364, getPrefernceSet() was undefined for VisualizationPreferencePage.

Also, I don't like that the getProperties() method in PropertySelector is made public in the patch. This exposes the implementation details of the Widget.  If it is changed at a later date (likely) to use a different method of maintaining the set of properties that are available for selection, then there will need to be changes in (newly) dependent code that doesn't currently exist.  Solution, for the moment, use more than one instance of the PropertySelector until it can support multiple property selection in a generic manner without knowledge of its implementation.
Comment 3 James Kaufman CLA 2007-10-12 13:38:08 EDT
Created attachment 80253 [details]
Stand Alone Time series Patch

Stand Alone Time series Patch does not required changes to property selector, Gets all properties to display from the decorator using it's own property sieve.
Comment 4 James Kaufman CLA 2007-10-12 13:40:34 EDT
I checked in a new, simpler, Stand Alone Time series Patch does not required changes to property selector, Gets all properties to display from the decorator using it's own property sieve.

This resolves the bug by using a single property selector and getting the list of displayable properties from the decorator. However, we need to modify the property selector either providing a constructor constant that allows us to hide the second (property) combo box - not used here, or to create a hierarchy with a top level "DecoratorSelector" class and a PropertySelector that inherits from it.
Comment 5 Daniel Ford CLA 2007-10-12 15:31:17 EDT
Committed patch from 10-12
Comment 6 Daniel Ford CLA 2007-10-12 15:40:26 EDT
I've been looking at how best to allow multiple property selection using the PropertySeleciton Widget and I'm not coming to any great conclusions on a solution.  The current CombBox approach works well for single selection, but the alternatives for multiple selection don't really seem appropriate.  We could replace the property ComboBox with a List that allows multiple selection, but that would require either more space than we want to give it or a scroll bar on the list of properties.  The other problem is that selecting multiple properties with a List isn't quite intuitive as it requires one to hold down the control key when making the selection, and then any selection without the control key causes all the other selections to be discarded.  I also looked at ExpandBar, but it doesn't seem to be what we want.  I was thinking of replacing the ComboBox with a menu that allowed multiple properties to be selected, with the selected ones being marked by a check mark.  This doesn't seem like quite the right context in which to place a menu.

Two other options come to mind.  1) Add "radio buttons", one for each property, to the Time Series composite where the current color legend is.  This could do double duty by being both a legend and a means for selecting the properties to display, 2) Add a pop-up menu for property selection much like the pop-up menu on the Map view.

#1 is more attractive to me.
Comment 7 James Kaufman CLA 2007-11-01 20:56:37 EDT
This bug is resolved already
Comment 8 Daniel Ford CLA 2007-11-02 09:55:28 EDT
How is it resolved?  It isn't possible to select what gets displayed?
Comment 9 Daniel Ford CLA 2008-07-17 09:33:33 EDT
closing
Comment 10 Daniel Ford CLA 2008-07-17 09:33:45 EDT
closed
Comment 11 Daniel Ford CLA 2009-10-29 14:14:15 EDT
Comment on attachment 80003 [details]
Shows all properteis in the time series display

flagged for iplog
Comment 12 Daniel Ford CLA 2009-10-29 14:14:28 EDT
Comment on attachment 80253 [details]
Stand Alone Time series Patch

flagged for iplog